Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning compares strings #1339

Open
jonpas opened this issue May 20, 2020 · 0 comments
Open

Versioning compares strings #1339

jonpas opened this issue May 20, 2020 · 0 comments
Labels

Comments

@jonpas
Copy link
Member

jonpas commented May 20, 2020

Mods (complete and add to the following information):

  • Arma 3: 1.98 stable
  • CBA: 3.15.1 stable
  • Any mod that requires another mod

Description:
When BUILD of a required mod is a string and requirement specifies only MAJOR.MINOR.PATCH (without BUILD), versioning will fail and see required BUILD as too low.

Without BUILD or number BUILD, it works fine.

Steps to reproduce:

  • Set BUILD of a mod to some string, eg. 3.15.1.something
  • Require that mod by just MAJOR.MINOR.PATCH, eg. CBA[] = {"cba_main", [3,15,1], "(true)"} (in CfgSettings)
  • Observe warning of "mod requires req_mod at version [...]"

Expected behavior:
Ignore comparison of that version part if it's not a comparable number. Build is not necessarily a number.

Where did the issue occur?

  • Load a mission or main menu mission.

Log Files:
Example:
21:31:04 WARNING: mymod requires acre_main (@ACRE) at version [2,7,3] (or higher). You have: [2,7,3,"1024-tac1"] where ACRE's build number is 1024-tac1.

Additional context:
Not a result of versioning changes in one of the recent versions, but only VERSION_AR which was around for a while. This might have always been the case and might just not be supported by design. However, build numbers can be anything, same would happen with CBA's date as build number if you'd put dashes into the date.

Screenshots:
/

@jonpas jonpas added the Bug label May 20, 2020
@jonpas jonpas changed the title Versioning force compares strings Versioning compares strings May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant