Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more characters in a Unicode warning #45

Open
vdancik opened this issue May 24, 2019 · 2 comments
Open

Include more characters in a Unicode warning #45

vdancik opened this issue May 24, 2019 · 2 comments
Assignees

Comments

@vdancik
Copy link

vdancik commented May 24, 2019

When issuing a warning about Unicode characters (#41), include few characters before/after the offending symbol - frequently it is a space (nbsp) or a dash (minus) and is difficult to locate.

@jagus7
Copy link

jagus7 commented Jun 21, 2019

As Zhou mentioned during the DB WG teleconference in May, the documentation should be developed to check the length violations and verify all the fields.

zhouji2013 added a commit that referenced this issue Jul 19, 2019
@zhouji2013
Copy link
Collaborator

The warning message containing the 'noncompliant' character is improved this way: the noncompliant character is shown along with up tp 5 characters before and after, respectively; the noncompliant character itself is displayed in red color.

Notice that for the sake of efficiency, once the first noncompliant character is found, the checking process stops. So if there are multiple consecutive noncompliant characters, only the first one is displayed in red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants