Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI that builds archives: #7

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

CI that builds archives: #7

wants to merge 15 commits into from

Conversation

walksanatora
Copy link
Contributor

@walksanatora walksanatora commented Jan 14, 2023 •
edited
Loading

Description

Fixes half of #5

Type of change

GithubActions

How Has This Been Tested?

by running it and tweaking the CC folder

Test Configuration:

  • read the workflow file

Checklist

  • My code follows the style guidelines of this project (all lints have passed)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Should i add Lua minification then PR it

@Commandcracker
Copy link
Member

minified-src is not minified ?_?

@walksanatora
Copy link
Contributor Author

yep currently minification is broken
i am working on it
but archive generation works
(the github action runs locally and works, but when running in actions it does not work)

@Commandcracker Commandcracker self-requested a review May 1, 2023 17:11
@Commandcracker Commandcracker added CI/CD CI/CD related issue enhancement New feature or request labels May 1, 2023
@Commandcracker Commandcracker linked an issue May 1, 2023 that may be closed by this pull request
Re: Minification and CI #5
Open
Commandcracker
Commandcracker requested changes May 1, 2023
View reviewed changes
Copy link
Member

@Commandcracker Commandcracker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the minified version of LD.lua with the original and add a comment with a link to the GH repo of LD.lua if there is one. Also Rename LD.lua to something more descriptive.

@walksanatora
Copy link
Contributor Author

walksanatora commented May 1, 2023 •
edited
Loading

you want to embed the full un-minified LD.lua?
(also i have alot of notifications today)

@Commandcracker
Copy link
Member

you want to embed the full un-minified LD.lua? (also i have alot of notifications today)

LibDeflate is only used to build it right ?
Then having the un-minified will help debugging

@walksanatora
Copy link
Contributor Author

I just noticed LibDeflate is not included in the computer :>

@Commandcracker
Copy link
Member

Commandcracker commented May 1, 2023 •
edited
Loading

It's ignoring symlinks in GH actions !?
(I'm using act)

| rom
LD.lua        buildimgs.lua rerun.txt
startup.lua   yc
Not a directory
[build] #opts 4
[build] output_base output/yc
[build] extraction path ''
[build] validating files
buildimgs.lua:40: File/Folder does not exist:
| yc/lib
| CC runner did not timeout

@walksanatora
Copy link
Contributor Author

yeah i am gonna have to add a run ln -s $PWD/yc ../../../src iirc

@Commandcracker
Copy link
Member

or cp :P

@walksanatora
Copy link
Contributor Author

why would I copy all the files from /src when I can just link them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Commandcracker Commandcracker Commandcracker requested changes

Assignees

@walksanatora walksanatora

@Commandcracker Commandcracker

Labels
CI/CD CI/CD related issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re: Minification and CI
2 participants
@walksanatora @Commandcracker