Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Filter.R #62

Open
sync-by-unito bot opened this issue Aug 19, 2024 · 1 comment
Open

Clean Filter.R #62

sync-by-unito bot opened this issue Aug 19, 2024 · 1 comment
Assignees
Labels
NIDAP sync with the NIDAP team's Trello board reneeTools RepoName
Milestone

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 19, 2024

on 8/16 Phil and Kelly discussed additional changes needed to clean up R/Filter.R script. Changes are denoted by TODO: in script with appropriate comments on work to be done

@sync-by-unito sync-by-unito bot added bug Something isn't working NIDAP sync with the NIDAP team's Trello board labels Aug 19, 2024
@kopardev kopardev added the reneeTools RepoName label Aug 19, 2024
@kelly-sovacool kelly-sovacool self-assigned this Sep 12, 2024
@kelly-sovacool kelly-sovacool added this to the 2024-09 milestone Sep 13, 2024
@kelly-sovacool
Copy link
Member

grep -n TODO R/*

R/filter.R:122:  # TODO we should use "feature" instead of "gene" to make sure this is applicable beyond RNA-seq
R/filter.R:124:  # TODO: just have users specify hex values directly for simplicity
R/filter.R:159:  # TODO separate slots in S7 for samples, counts, annotations --> create function to validate
R/filter.R:181:  # TODO move this function call to the S7 validator
R/filter.R:314:#' TODO this function also transforms raw counts to CPM, but that should be a separate function before this step, before filter_counts function()
R/filter.R:315:#' TODO document `isexpr1` column in output
R/heatmap.R:14:    # TODO this only works on dataframes, not tibbles
R/rename.R:3:#' TODO this should happen right at the beginning of the template?
R/rename.R:5:#' TODO accept new names for samples in sample metadata spreadsheet
R/rename.R:9:#' @param samples_to_rename_manually TODO use sample metadata spreadsheet custom column
R/rename.R:18:    # TODO: refactor with dplyr::rename for simplicity

@kelly-sovacool kelly-sovacool removed the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NIDAP sync with the NIDAP team's Trello board reneeTools RepoName
Projects
None yet
Development

No branches or pull requests

2 participants