Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for copying JSON data #328

Open
lexisother opened this issue Jul 26, 2024 · 4 comments
Open

Add an option for copying JSON data #328

lexisother opened this issue Jul 26, 2024 · 4 comments

Comments

@lexisother
Copy link
Member

When patching existing maps, it'd be handy if users could copy entire JSON structures of entities or properties of said entities (e.g. event in EventTrigger)

@Vegita2
Copy link
Member

Vegita2 commented Jul 28, 2024

Could you clarify your request? Currently, copying entities automatically copies their JSON to the clipboard. This could be expanded for other things that can be copied, like event/action steps. Is this what you mean?

@lexisother
Copy link
Member Author

Honestly, I completely forgot that copying entities also copies their data to the clipboard. However, copying data from main functions (event/action steps, NPC states) or even specific widgets would be handy as well.

@XenonA7
Copy link

XenonA7 commented Jul 29, 2024

Having event and action steps use the clipboard would be a huge improvement to the map editor, just as it was back when this feature was added to props. Being able to copy/paste event/action steps between different EventTrigger entities alone would greatly improve the user experience.

@XenonA7
Copy link

XenonA7 commented Jul 29, 2024

Something to consider is that there are a handful of event/action steps with identical names and data structures, such as WAIT. Copying a WAIT event step and pasting it into an action will probably work. However, there are quite a few steps unique to events or actions, and there are some steps like SHOW_EFFECT that exist as both event and action steps with slight differences between the two versions.

Generally, copying action steps into an event and vice versa will likely be a problem. New users will certainly not understand the difference between event/action steps because they look the same in the editor. I think there needs to be some sort of protection built-in for this if clipboard copy/paste is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants