Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Fix issues with new BlueprintJS version #12

Closed
10 tasks done
forman opened this issue Feb 28, 2020 · 16 comments
Closed
10 tasks done

Fix issues with new BlueprintJS version #12

forman opened this issue Feb 28, 2020 · 16 comments
Labels
blocker This blocks a release

Comments

@forman
Copy link
Member

forman commented Feb 28, 2020 •
edited by pont-us
Loading

Use of Blueprint 3.x introduced several new issues.

Coding issues:

  • Replace src/renderer/components/Card usages by @blueprintjs.core.Card

Styling issues:

  • Fix data store selector being too slim in width in DATA SOURCES panel.
  • Fix vertical non-alignment of green "Add tag" button and subsequently added tags in OPERATIONS panel.
  • Fix "Display range" input field not aligned with right-side "<->" button in STYLES panel.
  • Fix vertical non-alignment of icon and label in "Active view" control of VIEW panel.
  • Fix too large cell heights in LAYERS panel items.
  • Fix non-alignment of checkboxes and label text in LAYERS panel items.
  • Fix tooltip flickering in OPERATIONS panel (Add Step button).
  • Fix tooltip flickering in WORKSPACE panel (Resource/step properties, clean workspace buttons).
  • Fix tooltip flickering in VARIABLES panel (Create a time series button).
@forman
Copy link
Member Author

forman commented Mar 4, 2020 •
edited by pont-us
Loading

  • Fix text field style:

image

@forman forman added the prio High priority issue. Solve this after "blocker" and "bug". label Mar 4, 2020
@forman
Copy link
Member Author

forman commented Mar 4, 2020 •
edited by pont-us
Loading

  • Fix misalignment in workspace dialog boxes

image

@forman
Copy link
Member Author

forman commented Mar 25, 2020 •
edited by pont-us
Loading

  • Fix places list

image

@forman
Copy link
Member Author

forman commented Mar 27, 2020 •
edited by AliceBalfanz
Loading

  • Fix colour bars selector popup (scrollbars missing, cant get to the upper bars)

image

@forman forman mentioned this issue Aug 3, 2020
Closed
@AliceBalfanz
Copy link
Contributor

AliceBalfanz commented Aug 7, 2020 •
edited by pont-us
Loading

  • Fix Edit Operation Step- pop-up window

image

@forman
Copy link
Member Author

forman commented Aug 7, 2020 •
edited by pont-us
Loading

image

  • Icon too small

@forman
Copy link
Member Author

forman commented Aug 7, 2020 •
edited by pont-us
Loading

image

Note: this sub-issue has been transferred into Issue #88, since it's not a blocker.

  • Dataset labels don't grow into free space

To reproduce: drag to reduce width of left-hand panel, and horizontal scroll-bar will appear. Scroll right with the scroll bar to confirm that dataset label did not grow into available space. One fix/workaround might be to change to "overflow: 'auto'" in ScrollableContent's style to "overflow-inline: hidden", which stops the horizontal scrollbar appearing. But better to do this by creating a new VerticallyScrollableContent component to avoid the risk of breaking the other 10 panels that use ScrollableContent.

@forman
Copy link
Member Author

forman commented Aug 10, 2020 •
edited
Loading

image

  • Wrapping and spacing broken

@forman forman added the blocker This blocks a release label Aug 10, 2020
@forman
Copy link
Member Author

forman commented Aug 11, 2020

image

  • Wrapping and spacing broken

Fixed in https://github.com/CCI-Tools/cate-webui/tree/forman-64-file_choosers-v2

pont-us added a commit that referenced this issue Aug 12, 2020
@pont-us
Fix layout of operation step dialog
8af4704 
Fixes sub-issue
#12 (comment)
of Issue #12.
pont-us added a commit that referenced this issue Aug 12, 2020
@pont-us
Make icon larger in job failure dialog
451b9bd 
Fixes sub-issue
#12 (comment)
of Issue #12.
pont-us added a commit that referenced this issue Aug 12, 2020
@pont-us
Fix layout of operation step dialog
23109f8 
Fixes sub-issue
#12 (comment)
of Issue #12 (but there are still other alignment problems in this
dialog).
@pont-us
Copy link
Contributor

pont-us commented Aug 12, 2020 •
edited
Loading

alignment

  • Widgets vertically misaligned in operations dialogs

AliceBalfanz added a commit that referenced this issue Aug 12, 2020
@AliceBalfanz
fix tooltip flickering - related to issue #12
6f5dce2
AliceBalfanz added a commit that referenced this issue Aug 13, 2020
@AliceBalfanz
fix tooltip of AddStep #12
f3d76de
@AliceBalfanz AliceBalfanz mentioned this issue Aug 13, 2020
Merged
pont-us added a commit that referenced this issue Aug 13, 2020
@pont-us
Fix vertical alignment in operation dialogs
938cc60 
Fixes sub-issue
#12 (comment)
of Issue #12.
@pont-us pont-us mentioned this issue Aug 13, 2020
Merged
pont-us added a commit that referenced this issue Aug 14, 2020
@pont-us
Fix misalignment in workspace dialog boxes
42e4a78 
Fixes sub-issue
#12 (comment)
of Issue #12
@AliceBalfanz AliceBalfanz mentioned this issue Aug 14, 2020
Merged
pont-us added a commit that referenced this issue Aug 14, 2020
@pont-us
Fix vertical position of checkboxes in places list
c2813a3 
Fixes the "space!" aspect of sub-issue
#12 (comment)
of Issue #12.
pont-us added a commit that referenced this issue Aug 14, 2020
@pont-us
Fix layout of items in Layers panel
efa519a 
Fixes the following items in sub-issue
#12 (comment) of
Issue #12:

 - Fix too large cell heights in LAYERS panel items.
 - Fix non-alignment of checkboxes and label text in LAYERS panel items.
pont-us added a commit that referenced this issue Aug 14, 2020
@pont-us
Fix icon/label alignment in "Active view"
2ebed49 
Fixes item "Fix vertical non-alignment of icon and label in "Active
view" control of VIEW panel" in sub-issue
#12 (comment)
of Issue #12.
forman pushed a commit that referenced this issue Aug 16, 2020
@pont-us @forman
Fix misalignment in workspace dialog boxes
57fa022 
Fixes sub-issue
#12 (comment)
of Issue #12
forman pushed a commit that referenced this issue Aug 16, 2020
@pont-us @forman
Fix vertical position of checkboxes in places list
f2045f4 
Fixes the "space!" aspect of sub-issue
#12 (comment)
of Issue #12.
forman pushed a commit that referenced this issue Aug 16, 2020
@pont-us @forman
Fix layout of items in Layers panel
f0459b8 
Fixes the following items in sub-issue
#12 (comment) of
Issue #12:

 - Fix too large cell heights in LAYERS panel items.
 - Fix non-alignment of checkboxes and label text in LAYERS panel items.
forman pushed a commit that referenced this issue Aug 16, 2020
@pont-us @forman
Fix icon/label alignment in "Active view"
e340ed0 
Fixes item "Fix vertical non-alignment of icon and label in "Active
view" control of VIEW panel" in sub-issue
#12 (comment)
of Issue #12.
@pont-us
Copy link
Contributor

pont-us commented Aug 17, 2020 •
edited
Loading

screenshot

  • Fix horizontal positioning in "Add file data source" dialog

pont-us added a commit that referenced this issue Aug 17, 2020
@pont-us
Fix horizontal positioning in Add file data source
8b86b8a 
Fixes sub-issue 'Fix horizontal positioning in "Add file data source"
dialog' (
#12 (comment)
) of Issue #12.
@forman
Copy link
Member Author

forman commented Aug 17, 2020 •
edited
Loading

image

  • Add vert. gap between workspace list and checkbox

pont-us added a commit that referenced this issue Aug 17, 2020
@pont-us
Align "Add tag" button & tags in OPERATIONS panel
732b850 
Fixes item: 'Fix vertical non-alignment of green "Add tag" button and
subsequently added tags in OPERATIONS panel.' of sub-issue
#12 (comment) of
Issue #12.
pont-us added a commit that referenced this issue Aug 18, 2020
@pont-us
Fix width of data store selector
c107131 
Fixes item "Fix data store selector being too slim in width in DATA
SOURCES panel." of sub-issue
#12 (comment) of
Issue #12.
@AliceBalfanz
Copy link
Contributor

AliceBalfanz commented Aug 18, 2020 •
edited by pont-us
Loading

image_2020_08_18T08_17_05_809Z

  • Fix word wrapping in 'Remove Data Source'

@AliceBalfanz
Copy link
Contributor

AliceBalfanz commented Aug 18, 2020 •
edited by pont-us
Loading

image

  • Fix word wrapping in 'Open Dataset from File(s)'

@AliceBalfanz AliceBalfanz mentioned this issue Aug 18, 2020
Merged
@forman forman removed the prio High priority issue. Solve this after "blocker" and "bug". label Aug 18, 2020
pont-us added a commit that referenced this issue Aug 18, 2020
@pont-us
Replace components/Card by @blueprintjs.core.Card
51c1fa6 
Fixes item "Replace src/renderer/components/Card usages by
@blueprintjs.core.Card" from sub-issue
#12 (comment)
of Issue #12. Also removes src/renderer/components/Card.tsx, since
it's not used any more.
@pont-us pont-us mentioned this issue Aug 18, 2020
Open
1 task
@pont-us
Copy link
Contributor

pont-us commented Aug 18, 2020 •
edited
Loading

image_2020_08_18T14_09_35_483Z

  • Checkboxes and labels misaligned in Layers panel

Happens on Chrome but not on Firefox.

pont-us added a commit that referenced this issue Aug 18, 2020
@pont-us
Layers panel: fix checkbox/label misalignment
0203c61 
Fixes sub-issue
#12 (comment)
of Issue #12.
@pont-us
Copy link
Contributor

pont-us commented Aug 19, 2020

Closing since all sub-issues now have now been fixed.

@pont-us pont-us closed this as completed Aug 19, 2020
pont-us added a commit that referenced this issue Aug 19, 2020
@pont-us
Update CHANGES.md
6033127 
Add missing changes related to Issue #12 and Issue #33.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocker This blocks a release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@forman @pont-us @AliceBalfanz