Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve placeholder tutorial file pre-commit hook #366

Closed
dylanhmorris opened this issue Aug 6, 2024 · 1 comment
Closed

Improve placeholder tutorial file pre-commit hook #366

dylanhmorris opened this issue Aug 6, 2024 · 1 comment
Milestone
Backlog

Comments

@dylanhmorris
Copy link
Collaborator

From #364:

It might also be nice to update the hook so that it fails if the .rst files exist but are not identical to the expected placeholders.

Was not done in #365, as it requires a larger refactor and might be worth waiting for other breaking changes such as #231
@dylanhmorris dylanhmorris mentioned this issue Aug 6, 2024
Merged
@damonbayer damonbayer added this to the Backlog milestone Aug 19, 2024
@dylanhmorris
Copy link
Collaborator Author

I think we can close this as won't do because we should instead just do #459

@dylanhmorris dylanhmorris closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@dylanhmorris @damonbayer