Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standards In Plotting For Inference & Forecasting Output #381

Closed
AFg6K7h4fhy2 opened this issue Aug 15, 2024 · 2 comments
Closed

Standards In Plotting For Inference & Forecasting Output #381

AFg6K7h4fhy2 opened this issue Aug 15, 2024 · 2 comments
Milestone

Comments

@AFg6K7h4fhy2
Copy link
Collaborator

AFg6K7h4fhy2 commented Aug 15, 2024

Presently, Models in metaclass.py have a method called plot_posterior, which calls plot_posterior located in mcmcutils.py. The tutorial Fitting a hospital admissions-only model employs arviz cohesively throughout, and in previous discussions, MSR developers seemed to converge on using arviz abundantly.

Should Model be made to have additional plotting features, such as plot_trace or plot_ppc from arviz? If not, then can we develop some standards for what to plot after retrieving samples from our MSR models?

@damonbayer
Copy link
Collaborator

Agree in general that there should be support for more convenient plotting. If we go this direction, I think we should start with more support for converting model output to ArviZ InferenceData.

@AFg6K7h4fhy2
Copy link
Collaborator Author

Agree in general that there should be support for more convenient plotting. If we go this direction, I think we should start with more support for converting model output to ArviZ InferenceData.

Wrt your latter remark, I agree. I spent some time playing around with InferenceData because trace, HDI, and ppc plots are easier to use this way, but didn't get as far as I would like. Expected value for our inference / forecasting pipelines from really understanding arviz seems high. Hopefully #135 can demonstrate some arviz utilities not previously demonstrated.

@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the Backlog milestone Aug 15, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants