Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Up CDCGov Repository For cfaepim-MSR #382

Closed
AFg6K7h4fhy2 opened this issue Aug 15, 2024 · 4 comments
Closed

Set Up CDCGov Repository For cfaepim-MSR #382

AFg6K7h4fhy2 opened this issue Aug 15, 2024 · 4 comments
Assignees
Labels
clean up Good code that could be better

Comments

@AFg6K7h4fhy2
Copy link
Collaborator

At present, #135 has not been merged (this would entail the removal of many files on the basis that MSR is not the correct place for them) and is overlapping greatly with CDCgov/pyrenew-flu-light#1 in the sense that the author of this issue is writing plotting and hypothesis testing code (KS test) to evaluate cfaepim-MSR relative to cfaepim.

As has been briefly discussed between the author and @dylanhmorris, beyond a certain level of development, models constructed via MSR might be better contained within their own repositories. I believe that @damonbayer is roughly in agreement with this, possibly conditional on other checks being met.

Since DHM suggested this process of re-housing cfaepim-MSR be deferred until further evaluation work has been done, the author will not move forward with the hasty completion of this issue; rather, the issue exists as a placeholder for a task that will, in the near future, need to be done.

@AFg6K7h4fhy2 AFg6K7h4fhy2 added the clean up Good code that could be better label Aug 15, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the Backlog milestone Aug 15, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Aug 15, 2024
@damonbayer
Copy link
Collaborator

We should discuss names for this and the PyRenew-based wastewater repo.

@AFg6K7h4fhy2
Copy link
Collaborator Author

Noting here, since record only currently exists elsewhere, that the model in #313 will be given its own repository first before cfaepim-MSR is given its own repository.

@damonbayer
Copy link
Collaborator

Repo requested: https://github.com/cdcent/cfa-predict-github-repos-meta/issues/17

@damonbayer
Copy link
Collaborator

Repo exists: https://github.com/CDCgov/pyrenew-flu-light

@damonbayer damonbayer modified the milestones: R Sprint, Q Sprint Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better
Projects
None yet
Development

No branches or pull requests

2 participants