Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for InfectionsWithFeedback class #394

Open
dylanhmorris opened this issue Aug 19, 2024 · 3 comments
Open

Tests for InfectionsWithFeedback class #394

dylanhmorris opened this issue Aug 19, 2024 · 3 comments
Labels

Comments

@dylanhmorris
Copy link
Collaborator

All existing tests were able to pass with a bug in the InfectionsWithFeedback class. Only attempting to render the extending_pyrenew.qmd tutorial revealed it. We should have:

  1. A test confirming that InfectionsWithFeedback can be instantiated and sampled.
  2. A test comparing infections with feedback computed using the class to a manual computation.
@sbidari
Copy link
Collaborator

sbidari commented Sep 12, 2024

@dylanhmorris How should the additional tests be different from the ones here?
As far as I understand this test verifies that InfectionWithFeedback class can be instantiated, sampled from, and compares the
Rt and Infections sampled from this class with the ones computed using a more straightforward method.

@dylanhmorris
Copy link
Collaborator Author

This is a lesson to me always to write a reprex, since the tests you're pointing to are almost exactly what I described and evidently didn't catch the bug. Let me investigate.

@damonbayer
Copy link
Collaborator

@dylanhmorris Were you able to investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants