You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All existing tests were able to pass with a bug in the InfectionsWithFeedback class. Only attempting to render the extending_pyrenew.qmd tutorial revealed it. We should have:
A test confirming that InfectionsWithFeedback can be instantiated and sampled.
A test comparing infections with feedback computed using the class to a manual computation.
The text was updated successfully, but these errors were encountered:
@dylanhmorris How should the additional tests be different from the ones here?
As far as I understand this test verifies that InfectionWithFeedback class can be instantiated, sampled from, and compares the Rt and Infections sampled from this class with the ones computed using a more straightforward method.
This is a lesson to me always to write a reprex, since the tests you're pointing to are almost exactly what I described and evidently didn't catch the bug. Let me investigate.
All existing tests were able to pass with a bug in the
InfectionsWithFeedback
class. Only attempting to render theextending_pyrenew.qmd
tutorial revealed it. We should have:InfectionsWithFeedback
can be instantiated and sampled.The text was updated successfully, but these errors were encountered: