As a RS developer, I want a consistent way to read HL7 messages

[mkalish]

User Story

As a RS developer, I want a consistent way to read HL7 messages

Description/Use Case

As part of refactoring the FhirConverter function an updated method of being able to parse HL7 messages was introduced, but only used in the new code. This function should be used throughout the code base where we read HL7 messages

Risks/Impacts/Considerations

Dev Notes

HL7Reader now contains two main methods for reading an HL7v2 message:

• getMessages - the old one to be replaced that supports multiple different class definitions per message type
• parseHL7Message the new one that supports only one "mega" class definition per message type

All usages of getMessages should be replaced with parseHL7Message. Once that is done, all methods that were used only by getMessages should be removed.

Acceptance Criteria

• parseHL7Message is used everywhere HL7 is parsed in the universal pipeline. Search for this in codebase: // TODO: https://github.com/CDCgov/prime-reportstream/issues/14116
• HL7Reader has any unused code cleaned up

To Do

• Remove old code from HL7Reader that is used places other than UP #16901
• Remove validation from SubmissionReceiver #16902
• Remove HL7MessageParseAndConvertConfiguration as a concept #16904

[Andrey-Glazkv]

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @jack-h-wang @jalbinson @JFisk42 @mkalish @thetaurean

[Andrey-Glazkv]

Please add your planning poker estimate with Zenhub @david-navapbc

[MichaelEsuruoso]

Spillover-Resource Unavailability- out three days of the sprint and I've been on call for two

[MichaelEsuruoso]

@adegolier to peer with @jack-h-wang to look into this item.

[adegolier]

Unforseen complications not mentioned in the ticket led to more resources than anticipated being required.

[adegolier]

Instead of gutting getMessages() and having it return a List parsed through parseHL7Message(), which is what I was almost finished with, was told that it should be deleted entirely, so spent yesterday fixing all the places that were expecting a list and am now back to the same question of whether we care that the new method no longer provides logging.

[adegolier]

Working my way through the tests that broke in the rework and figuring out why they're broken now and how to fix them (whether that means changing the code or changing the tests):

• SubmissionReceiver
• HL7ACKUtils
• FHIRBundleHelpers
• HL7Reader
• HL7QueueMessageHelpers

[MichaelEsuruoso]

Spillover-Resource Unavailability- Deployment duties conflict with sprint work.