Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

names vocab: allow names vocab to have 2 types of objects #193

Milestone

Comments

@jrcastro2
Copy link
Contributor

jrcastro2 commented Sep 2, 2024

There will be 2 types of objects in the names vocab: the ORCID objects, and the CERN objects.

The ORCID objects are inserted or updated via the automatic jobs/dump. Its IDs cannot really be changed as all the code relies on having the ORCID as the id:

- affiliations:
  - name: Northwestern University
  family_name: Findler
  given_name: Robby
  id: 0000-0002-4245-2000
  identifiers:
  - identifier: 0000-0002-4245-2000
    scheme: orcid

The CERN objects could look like this (check props definition in other vocabs):

- affiliations:
  - name: <affiliations from CERN db>
  family_name: Findler
  given_name: Robby
  id: <encrypted-person-id>
  props:
    e-mail: <email>
    username: <username>
    is_cern: True
  identifiers:
  - identifier: <encrypted-person-id>
    scheme: CERN

In general, the vocabularies schemas and features should be enhanced to support:

  1. extra fields for the names. It looks like that it is not the case today, see here.
  2. vocabularies should support deprecation.

On ldap sync the authors synced should be added as names

@jrcastro2 jrcastro2 moved this to In progress in Sprint Q4/2024 🍂 Sep 2, 2024
@jrcastro2 jrcastro2 self-assigned this Sep 2, 2024
jrcastro2 added a commit to jrcastro2/invenio-vocabularies that referenced this issue Sep 4, 2024
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Sep 4, 2024
jrcastro2 added a commit to jrcastro2/invenio-vocabularies that referenced this issue Sep 19, 2024
jrcastro2 added a commit to jrcastro2/invenio-rdm-records that referenced this issue Sep 19, 2024
jrcastro2 added a commit to jrcastro2/invenio-rdm-records that referenced this issue Sep 19, 2024
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Sep 19, 2024
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Sep 19, 2024
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Sep 19, 2024
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Sep 20, 2024
jrcastro2 added a commit to jrcastro2/invenio-rdm-records that referenced this issue Sep 20, 2024
jrcastro2 added a commit to jrcastro2/invenio-theme that referenced this issue Sep 20, 2024
jrcastro2 added a commit to jrcastro2/cds-rdm that referenced this issue Sep 20, 2024
@ntarocco ntarocco added this to the SSPN milestone Oct 7, 2024
jrcastro2 added a commit to jrcastro2/invenio-vocabularies that referenced this issue Oct 11, 2024
jrcastro2 added a commit to jrcastro2/invenio-vocabularies that referenced this issue Oct 22, 2024
@jrcastro2 jrcastro2 removed their assignment Oct 22, 2024
@ntarocco
Copy link
Contributor

At the end, we will need to update this issue with the latest implementation

jrcastro2 added a commit to jrcastro2/react-invenio-forms that referenced this issue Nov 7, 2024
@jrcastro2 jrcastro2 self-assigned this Nov 8, 2024
jrcastro2 added a commit to jrcastro2/invenio-vocabularies that referenced this issue Nov 8, 2024
jrcastro2 added a commit to jrcastro2/react-invenio-forms that referenced this issue Nov 8, 2024
jrcastro2 added a commit to jrcastro2/invenio-accounts that referenced this issue Nov 8, 2024
jrcastro2 added a commit to jrcastro2/invenio-db that referenced this issue Nov 8, 2024
jrcastro2 added a commit to jrcastro2/react-invenio-forms that referenced this issue Nov 11, 2024
@jrcastro2 jrcastro2 removed their assignment Nov 11, 2024
@jrcastro2 jrcastro2 removed their assignment Nov 13, 2024
jrcastro2 added a commit to jrcastro2/react-invenio-forms that referenced this issue Nov 14, 2024
jrcastro2 added a commit to jrcastro2/react-invenio-forms that referenced this issue Nov 14, 2024
@github-project-automation github-project-automation bot moved this from In review 🔎 to To release 🤖 in Sprint Q4/2024 🍂 Nov 14, 2024
jrcastro2 added a commit to inveniosoftware/invenio-theme that referenced this issue Nov 14, 2024
jrcastro2 added a commit to inveniosoftware/invenio-db that referenced this issue Nov 14, 2024
jrcastro2 added a commit to inveniosoftware/invenio-vocabularies that referenced this issue Nov 14, 2024
* names: add props
* permissions: restrict unlisted values
* names: allow resolver to return multiple values
* closes CERNDocumentServer/cds-rdm#193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment