Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: Incorrect error handling in frontend when login using OIDC failed #985

Open
1 of 4 tasks
psrok1 opened this issue Sep 30, 2024 · 0 comments
Open
1 of 4 tasks
Labels
type:bug Something isn't working zone:frontend MWDB frontend tasks

Comments

@psrok1
Copy link
Member

psrok1 commented Sep 30, 2024

Environment information

  • MWDB version (from /about): v2.13.0
  • Installation method:
    • mwdb.cert.pl service
    • From PyPi (pip install mwdb-core)
    • From docker-compose
    • Other (please explain)
  • Plugins installed:

Behaviour the bug (what happened?)

When user tries to log in using OIDC and doesn't have account yet, they're asked to register a new one, but "Unknown identity" error appears in the same time.

image

It's a bit worse when we decline the consent for a requested scope. Sometimes OpenID providers are redirecting us back to the application with error= set in URI. In that case, user is incorrectly asked to register an account once again.

image

Expected behaviour

  • Error should not appear in case of non-existent identity
  • Error should appear in other cases, but prompt for registration should not appear.
@psrok1 psrok1 added zone:frontend MWDB frontend tasks type:bug Something isn't working labels Sep 30, 2024
@psrok1 psrok1 changed the title OIDC: Better error handling when login using OIDC failed OIDC: Insufficient error handling when login using OIDC failed Sep 30, 2024
@psrok1 psrok1 changed the title OIDC: Insufficient error handling when login using OIDC failed OIDC: Incorrect error handling when login using OIDC failed Sep 30, 2024
@psrok1 psrok1 changed the title OIDC: Incorrect error handling when login using OIDC failed OIDC: Incorrect error handling in frontend when login using OIDC failed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working zone:frontend MWDB frontend tasks
Projects
None yet
Development

No branches or pull requests

1 participant