Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake warning calling find_package(DDC) #755

Closed
tpadioleau opened this issue Jan 13, 2025 · 6 comments · Fixed by #758
Closed

CMake warning calling find_package(DDC) #755

tpadioleau opened this issue Jan 13, 2025 · 6 comments · Fixed by #758

Comments

@tpadioleau
Copy link
Member

The CI reports this kind of warning:

CMake Warning (dev) at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args`
  (Kokkos_DEVICES) does not match the name of the calling package (DDC).
  This can lead to problems in calling code that expects `find_package`
  result variables (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /data/opt/kokkos/lib/cmake/Kokkos/KokkosConfigCommon.cmake:110 (find_package_handle_standard_args)
  /data/opt/ddc/lib/cmake/DDC/DDCCheckRequiredKokkosOptions.cmake:6 (kokkos_check)
  /data/opt/ddc/lib/cmake/DDC/DDCConfig.cmake:44 (ddc_check_required_kokkos_options)
  CMakeLists.txt:9 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

It comes from the kokkos_check macro that calls find_package_handle_standard_args.

@tpadioleau
Copy link
Member Author

see kokkos/kokkos#7669

@tpadioleau
Copy link
Member Author

@EmilyBourne Do you find it annoying ? I should be able to workaround this on the DDC side.

@EmilyBourne
Copy link
Collaborator

EmilyBourne commented Jan 21, 2025

I'm not sure I'm the right person to ask. I have not noticed this message on my laptop.

I have just recompiled and it does not appear locally.

@tpadioleau
Copy link
Member Author

It will appear after updating DDC to version 0.4

@EmilyBourne
Copy link
Collaborator

Ah, then this is likely to annoy me. But not enough to complain about it. It's up to you depending on how easy/hard your workaround is.

@tpadioleau
Copy link
Member Author

It can be removed actually, it is just a helper to diagnose in case there is a problem when an environment has multiple kokkos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants