Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processFile silently fails if there is any error #62

Open
RaphaelIT7 opened this issue Sep 21, 2024 · 0 comments
Open

processFile silently fails if there is any error #62

RaphaelIT7 opened this issue Sep 21, 2024 · 0 comments

Comments

@RaphaelIT7
Copy link

RaphaelIT7 commented Sep 21, 2024

So I noticed that I had a few broken tests when I went thru the logs and I never noticed it before.
This should probably let the workflow fail or throw a warning to make it more apparent that there's an error.
Yes the workflow is from gmod_tests but the error itself is in GLuaTest.

Example(Look at the Run GLuaTest step): https://github.com/CFC-Servers/gmod_tests/actions/runs/9877474323/job/27279166133

L 07/10/2024 - 15:55:35: Lua Error: 
[project] addons/project/lua/tests/gmod/classes/convar/isflagset.lua:57: '<name>' expected near '='
  1. processFile - addons/gluatest/lua/gluatest/loader.lua:24
   2. getTestsInDir - addons/gluatest/lua/gluatest/loader.lua:48
    3. getTestsInDir - addons/gluatest/lua/gluatest/loader.lua:53
     4. loader - addons/gluatest/lua/gluatest/loader.lua:53
      5. loadAllProjectsFrom - addons/gluatest/lua/gluatest/init.lua:43
       6. runAllTests - addons/gluatest/lua/gluatest/init.lua:59
        7. v - addons/gluatest/lua/gluatest/init.lua:69
         8. unknown - lua/includes/modules/hook.lua:[96](https://github.com/CFC-Servers/gmod_tests/actions/runs/9877474323/job/27279166133#step:7:97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant