MQTT ring buffer should be protected in subscribe callbacks #43
Assignees
Comments
|
Oops, sounds right, looks like I missed this. I added it to my TODO list, but go ahead if you want to do the fix! |
hlef
added a commit
that referenced
this issue
Oct 22, 2024
The `topic` and `payload` capabilities of the publish callback are only valid within the context of the callback. They should thus passed as a read-only, non-capturable capabilities. Currently we pass them as capturable and writable capabilities, which may allow API users to compromise the MQTT compartment. This addresses issue #43. Signed-off-by: Hugo Lefeuvre <[email protected]>
|
Note: I fixed this in my |
hlef
added a commit
that referenced
this issue
Oct 24, 2024
The `topic` and `payload` capabilities of the publish callback are only valid within the context of the callback. They should thus passed as a read-only, non-capturable capabilities. Currently we pass them as capturable and writable capabilities, which may allow API users to compromise the MQTT compartment. This addresses issue #43. Signed-off-by: Hugo Lefeuvre <[email protected]>
hlef
added a commit
that referenced
this issue
Oct 24, 2024
The `topic` and `payload` capabilities of the publish callback are only valid within the context of the callback. They should thus passed as a read-only, non-capturable capabilities. Currently we pass them as capturable and writable capabilities, which may allow API users to compromise the MQTT compartment. This addresses issue #43. Signed-off-by: Hugo Lefeuvre <[email protected]>
hlef
added a commit
that referenced
this issue
Oct 24, 2024
The `topic` and `payload` capabilities of the publish callback are only valid within the context of the callback. They should thus passed as a read-only, non-capturable capabilities. Currently we pass them as capturable and writable capabilities, which may allow API users to compromise the MQTT compartment. This addresses issue #43. Signed-off-by: Hugo Lefeuvre <[email protected]>
hlef
added a commit
that referenced
this issue
Oct 29, 2024
The `topic` and `payload` capabilities of the publish callback are only valid within the context of the callback. They should thus passed as a read-only, non-capturable capabilities. Currently we pass them as capturable and writable capabilities, which may allow API users to compromise the MQTT compartment. This addresses issue #43. Signed-off-by: Hugo Lefeuvre <[email protected]>
|
This was fixed as part of #46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The MQTT subscribe callback gets passed a reference to part of the receive buffer used by coreMQTT for incoming messages. We should pass this as a read-only, non-capturable capabilty, since outside of the context of the callback it's content is not valid.
The text was updated successfully, but these errors were encountered: