Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with C# < 7 #35

Open
alelom opened this issue Sep 22, 2021 · 1 comment
Open

Compatibility issue with C# < 7 #35

alelom opened this issue Sep 22, 2021 · 1 comment
Labels
severity:medium Slows progress, but workaround is possible

Comments

@alelom
Copy link
Contributor

alelom commented Sep 22, 2021

@buka71

The following property:

public List<(float, float)> Outline { get; set; }

breaks compilation for Visual Studio versions from 2017 and below. We try to use features that are a bit more compatible for everyone.

It would be good to replace that to a List<Tuple<float,float>>

@alelom alelom added the severity:medium Slows progress, but workaround is possible label Sep 22, 2021
@natalia-wz
Copy link
Member

@alelom

List<Tuple<float,float>> causes conflicts within the Unity project (at compilation), I should have raised that as an issue when pushing RoomObject.cs; we can comment out the line for now and close the issue. In the future, we can follow it up with restructuring in Unity and updating RoomObject.cs to match (it won't be a list of tuples, but we can use sth else)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:medium Slows progress, but workaround is possible
Projects
None yet
Development

No branches or pull requests

2 participants