Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the file extension (.json|.nc) into an option #9

Open
jameshalgren opened this issue Oct 11, 2023 · 2 comments
Open

Bring the file extension (.json|.nc) into an option #9

jameshalgren opened this issue Oct 11, 2023 · 2 comments

Comments

@jameshalgren
Copy link
Member

On this line,

file.write(f"{item}.json\n")

we might consider using a default file extension in a variable that we pass into the function call. That way, if someone comes up with parquet files or some other extension, we don't have issues with that.

@sepehrkrz
Copy link

File extensions depend on the urlbaseinput chosen value and it is already determined in the code based on that value.

sepehrkrz added a commit that referenced this issue Oct 31, 2023
@jameshalgren
Copy link
Member Author

Perhaps we can make this a bit more modular in a refactoring pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants