-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alchemy CMS to the scanner #39
Comments
@robinboening can you tell us how this can be done? With an example version & detection file? |
Hey @zero-24, thanks for asking. I wanted to assign myself since I already started working on that, but I think only admins of the repo can. |
done 👍 |
do you also work on installed extension detection? |
Thanks for assigning me! 👍 My plan is to finish the basic detection first and then see how the extension detection works and implement that for Alchemy CMS also, yes. Since I haven't seen php code for 10 years now I need to find my way into it again. |
Let me know if i can help you. You can contact me via tobias.zulauf[at-sign]community.joomla.org if you need help with the PHP Code. Maybe the examples for Joomla or WP etc. can help you 😄 |
Just as tip for the extension detection you can have a look into the e.g. here: https://github.com/CMS-Garden/cmsscanner/blob/feature/whd-hackathon/src/Detector/Adapter/JoomlaAdapter.php#L391 |
Thanks. Yes, I branched from Lets see where it goes :) First I need to get the tests running locally. |
PR landed: #40 |
Closing as there is a PR 👍 |
I have just noticed that the PR just add the cms detection. So i reponen here as the extension detection is still open. |
👍 Yep, exactly. Thank you! |
@robinboening any update regarding the extension detection features? |
The text was updated successfully, but these errors were encountered: