Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH Queue Page Route [final version] #50

Merged
merged 9 commits into from
Oct 9, 2024
Merged

OH Queue Page Route [final version] #50

merged 9 commits into from
Oct 9, 2024

Conversation

kmehta5
Copy link

@kmehta5 kmehta5 commented Oct 3, 2024

Resolves #16

Features added:
Able to access OH Queue from side nav bar. Working routes and controller for the OH Queue page.

Changes made:
Created a route in src/routes/index.js. Created added api route to public/openapi/read.yaml by creating public/openapi/read/oh-queue.yaml.

Files changed:
public/openapi/read.yaml
public/openapi/read/oh-queue.yaml
src/api/oh-queue.js
src/controllers/ohQueue.js
src/routes/index.js

WhatsApp Image 2024-10-06 at 15 37 01_bb591f53

@kmehta5 kmehta5 added this to the Sprint 2 milestone Oct 6, 2024
@kmehta5 kmehta5 requested a review from anna-mat October 6, 2024 19:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11204532002

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 82.673%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
src/user/approval.js 3 87.61%
Totals Coverage Status
Change from base Build 11113198837: -0.01%
Covered Lines: 22331
Relevant Lines: 25591

💛 - Coveralls

Copy link

@anna-mat anna-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Glad you were able to resolve the issues brought up by the linter and the code is now passing the tests.

@anna-mat anna-mat changed the title OH Queue route OH Queue Page Route [final version] Oct 9, 2024
@anna-mat anna-mat added the enhancement New feature or request label Oct 9, 2024
@kmehta5 kmehta5 merged commit c2a080d into CMU-313:f24 Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Queue Page
3 participants