Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the role of malsplitbinary_cursor_get_bitfield_length? #28

Open
gbonnefille opened this issue Jun 6, 2017 · 0 comments
Open

Comments

@gbonnefille
Copy link
Contributor

gbonnefille commented Jun 6, 2017

The function malsplitbinary_cursor_get_bitfield_length gives a result really different from the bitfield_length attribute member of malsplitbinary_cursor_t. And the result seems incorrect when used for a cursor created by a decoder (cf. malsplitbinary_decoder_cursor_init).

Should we remove this function?
Should we initialise the most_significant attribute member in the decode context?
Should we rename this function?

Nevertheless, the bitfield_length attribute member contains the length (in bit) of the effective bitfield, while the malsplitbinary_cursor_get_bitfield_length returns the length (in byte) of the bitfield plus its encoded length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant