Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for test_matrix_a in gbmv,tbmv,hbmv and sbmv #559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andreimatraguna
Copy link

@andreimatraguna andreimatraguna commented Aug 28, 2024

This resolves #538.

@CNugteren CNugteren self-requested a review August 28, 2024 14:06
Copy link
Owner

@CNugteren CNugteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I misunderstood the original issue, I don't think what you implemented here is correct. By changing clblast.h you are giving the option to the user to control whether or not the matrix A should be tested, but I thought the original issue was not about a new feature but about correctness: this matrix should be tested or it shouldn't, that is not up to the user.

Please correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banded matrices required buffer size calculated incorrectly (GBMV, HBMV, SBMV & TBMV)
4 participants