Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoolTupleReader logic rework. #124

Open
hugy718 opened this issue Jan 7, 2023 · 0 comments
Open

CoolTupleReader logic rework. #124

hugy718 opened this issue Jan 7, 2023 · 0 comments
Assignees
@hugy718
Labels
logic-issue problems about the main logic

Comments

@hugy718
Copy link
Collaborator

hugy718 commented Jan 7, 2023

Reasons:

  • change in cohort storage format. global id list > string list
  • global id no longer unique across cublet
  • previous impl assumes that users with unique id and the order in cohort file and raw data are the same.

plan

map string to global id at the beginning for each cublet.
iterate through data and check if user is contained in the target cohort list for the cublet

status

comment out CoolTupleReader for now. The downstream exploration application is already commented
@hugy718 hugy718 added the logic-issue problems about the main logic label Jan 7, 2023
@hugy718 hugy718 self-assigned this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugy718 hugy718

Labels
logic-issue problems about the main logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hugy718