Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix team member avatar #106

Closed
wants to merge 6 commits into from
Closed

Fix team member avatar #106

wants to merge 6 commits into from

Conversation

EshaanAgg
Copy link
Contributor

Description

If the avatar image can't be fetched, then instead a simple avatar with the initials of the team member is shown.

Fixes

Fixes #104 by @EshaanAgg

Types of changes

  • Bug/Hot fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring Old Code ( non-breaking change replacing already existing code )
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guidelines in repository.
  • My pull request has a descriptive title and is attached to an existing issue.
  • I haven't repeated the code and it follows established code style of repository.
  • My branch is up-to-date with upstream branch.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Oct 2, 2022 •
edited
Loading

✅ Deploy Preview for cops ready!

Name Link
🔨 Latest commit 3c97cb7
🔍 Latest deploy log https://app.netlify.com/sites/cops/deploys/633aec2f9a8bbc0009c2d4cf
😎 Deploy Preview https://deploy-preview-106--cops.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@IamEzio
Copy link
Member

IamEzio commented Oct 2, 2022

@EshaanAgg I cannot see the changes in the netlify preview. PTAL

@EshaanAgg
Copy link
Contributor Author

EshaanAgg commented Oct 2, 2022 •
edited
Loading

@IamEzio
The differences can be seen for two members - Yash Prakash and Ravidev Pandey.
Attaching the relevant screenshots:

Before

image

image

Current

image

image

@IamEzio
Copy link
Member

IamEzio commented Oct 3, 2022

The changes look fine but they are not visible on the deploy preview. Just wanna make sure that they don't actually break the site instead of adding a new feature. Take a look on it and try to fix it if possible. Its not the case with netlify being not able to access GitHub api because the team page loads perfectly well on the deploy preview of other PRs.

@EshaanAgg
Copy link
Contributor Author

The screenshots that I have attached are from the deploy preview itself.
image
Can't seem to find a reason that they won't be visible to you.

@EshaanAgg EshaanAgg closed this by deleting the head repository Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EshaanAgg EshaanAgg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: No default avatar on Team Page
2 participants
@EshaanAgg @IamEzio