Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Problems migrating to AndroidX #25

Open
BumbleFlash opened this issue Jun 22, 2020 · 2 comments
Open

Problems migrating to AndroidX #25

BumbleFlash opened this issue Jun 22, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@BumbleFlash
Copy link

Firebase 17+ versions use JetPack (or Androidx). Some material design libraries like BottomSheetView don't build when migrated to AndroidX.

When firebase is upgraded to 17, without migrating to androidx, the manifest merger fails. The error message looks like this:

Manifest merger failed : Attribute application@appComponentFactory value=(android.support.v4.app.CoreComponentFactory) from [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91

@barbeau
Copy link
Member

barbeau commented Jun 22, 2020

Thanks @BumbleFlash! For some context, we were looking to update Crashlytics to fix this release variant issue - #24.

@barbeau barbeau changed the title Firebase Crashlytics incompatibility Firebase Crashlytics incompatibility with AndroidX Jun 22, 2020
@barbeau barbeau changed the title Firebase Crashlytics incompatibility with AndroidX Problems migrating to AndroidX Jun 22, 2020
@BumbleFlash
Copy link
Author

Update: @barbeau I tried refactoring the code mostly by updating the imports to androidx.core and some of them didn't require a lot of changes. However, there are classes that use LayoutInflator (deprecated in androidx) that need major code changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants