Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Gradient Support" option does not work correctly on aggregate graphs #5267

Open
ISekan opened this issue Mar 10, 2023 · 12 comments
Open
Assignees
Labels
3rd Party Change Something that Cacti can't fix directly enhancement General tag for an enhancement gradient Gradient related issues
Milestone

Comments

@ISekan
Copy link

ISekan commented Mar 10, 2023

Cacti 1.2.24
It works properly only for first item.
Is this a bug or a feature?
image
image

@ISekan ISekan added bug Undesired behaviour unverified Some days we don't have a clue labels Mar 10, 2023
@TheWitness
Copy link
Member

I looked at making it work with AREA:STACK and it did not look good. So, I reverted it. It's an open issue though.

@TheWitness
Copy link
Member

TheWitness commented Mar 10, 2023

It's more of a technical issue as the method that the contributor used basically renders several quadrants over one another with varying colors. Each area renders from the bottom of the Y-Axis upto the path. So, the final gradient becomes all washed out, and it also does not work well with AREA's on top of AREA's due to the fact the design does not allow for Alpha Transparency. It's all technical, might be able to be fixed, but it was beyond the 1.2.x scope. Maybe we can do something in 1.3.x.

@TheWitness TheWitness added this to the v1.3.0 milestone Mar 23, 2023
@TheWitness TheWitness added enhancement General tag for an enhancement and removed bug Undesired behaviour unverified Some days we don't have a clue labels Mar 23, 2023
@thurban
Copy link
Contributor

thurban commented Apr 3, 2023

Can you test out this rrd.php file ? replace the original lib/rrd.php with it, make a backup first.

It should suport Stack and Aggregate graphs. Some graphs seem to have very light lines in them (mainly seen when using red with transparency)

This is for testing purposes, please make screenshots of any issues you are seeing. It uses a light theme, so gradient is going to a lighter color.

lib_rrd_1.2.24.zip

@thurban
Copy link
Contributor

thurban commented Apr 3, 2023

To be clear for going forward:

  • Gradient support will be per graph template instead of global
  • Support for a light/dark mode (color going to a lightened or darkened version)
  • Changes will be in 1.3.x only

@ISekan
Copy link
Author

ISekan commented Apr 3, 2023

thurban of course
It works, but need to some adjustment

image
image
image
image

@thurban
Copy link
Contributor

thurban commented Apr 3, 2023

Yeah. Unfortunaltey this seems to be a rrdtool bug. If you disable "slopemode" on the graphs, it looks better, but rrdtool seems to slightly overlap the different areas, resulting in these lines. It doesn't show when no transparency is being used as it is a solid color then.

I'm looking into finding a fix for that, but it's going to take a while.

@thurban
Copy link
Contributor

thurban commented Apr 4, 2023

@ISekan It looks like the version breaks the "Thumbnails". Can you confirm ?
-> Seems like this only occurrs under very specific conditions ( very short time range )

@thurban
Copy link
Contributor

thurban commented Apr 4, 2023

@ISekan you do not happen to have the possibility to compile rrdtool yourself ?

@thurban
Copy link
Contributor

thurban commented Apr 4, 2023

Opened a bug report with rrdtool:
oetiker/rrdtool-1.x#1219

@ISekan
Copy link
Author

ISekan commented Apr 4, 2023

you do not happen to have the possibility to compile rrdtool yourself ?
Unfortunately not
I have ver. RRD 1.7.1 on the cacti server

@ISekan
Copy link
Author

ISekan commented Apr 6, 2023

Seems like this only occurrs under very specific conditions ( very short time range )
poller time is 1min
If time preset is set 12h - all's ok, After switch to 1 day or more it is look no so good as you can see below
image
image

@thurban
Copy link
Contributor

thurban commented Apr 6, 2023

Hi,

Not sure, but I don't see any gradient there, do I miss something ?

@TheWitness TheWitness added 3rd Party Change Something that Cacti can't fix directly gradient Gradient related issues labels Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd Party Change Something that Cacti can't fix directly enhancement General tag for an enhancement gradient Gradient related issues
Projects
None yet
Development

No branches or pull requests

3 participants