Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Hydrogen 0.3.1 increases memory usage in 1.17.1 #54

Open
FwuffyPetsOwO opened this issue Aug 1, 2021 · 2 comments
Open

Hydrogen 0.3.1 increases memory usage in 1.17.1 #54

FwuffyPetsOwO opened this issue Aug 1, 2021 · 2 comments

Comments

@FwuffyPetsOwO
Copy link

FwuffyPetsOwO commented Aug 1, 2021

Using Hydrogen 0.3.1 with 1.17.1 increases memory usage compared to without Hydrogen. Hydrogen 0.3.0 does not have this issue.

Vanilla environment test results: https://discord.com/channels/602796788608401408/602805971391217683/871254018310152313

Modpack "Valhesia Fabric 1.17" results: https://discord.com/channels/602796788608401408/602805971391217683/871260901808959538

Modpack with Hydrogen 0.3.0: https://discord.com/channels/602796788608401408/602805971391217683/871265091536973864

It seems 0.3.1 is causing some regression compared to 0.3.0

@ghost
Copy link

ghost commented Sep 9, 2021

Using Hydrogen 0.3.1 with 1.17.1 increases memory usage compared to without Hydrogen. Hydrogen 0.3.0 does not have this issue.

Vanilla environment test results: https://discord.com/channels/602796788608401408/602805971391217683/871254018310152313

Modpack "Valhesia Fabric 1.17" results: https://discord.com/channels/602796788608401408/602805971391217683/871260901808959538

Modpack with Hydrogen 0.3.0: https://discord.com/channels/602796788608401408/602805971391217683/871265091536973864

It seems 0.3.1 is causing some regression compared to 0.3.0

Can you post screenshots on imgur they are not available on the discord link
so it will be easier for the creators of the mod to fix the problem
(i'm not a creator) just wondering

@amnotbananaama
Copy link

Note that the only code change from 0.3.0 to 0.3.1 was e64d970, which simplifies Hydrogen's code to assume Java 16 is used.

Echoing the comment above to please send your results to an image hosting site or uploading them directly to a GitHub comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants