Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Error Contexts are not implemented for NeoForge #2671

Open
mrmangohands opened this issue Aug 15, 2024 · 4 comments
Open

No Error Contexts are not implemented for NeoForge #2671

mrmangohands opened this issue Aug 15, 2024 · 4 comments
Assignees
Labels
A-portability Area: Platform portability P-low Priority: Low S-blocked Status: Blocked by another issue/merge T-bug Type: Bug

Comments

@mrmangohands
Copy link
Member

mrmangohands commented Aug 15, 2024

Bug Description

The mixin in core/WindowMixin was updated and commented out during the multiloader merge, may need further changes
https://github.com/CaffeineMC/sodium-fabric/blob/acb25b4e10961dd5ad0149e6fe6536519cc8d521/common/src/main/java/net/caffeinemc/mods/sodium/mixin/core/WindowMixin.java#L13

@mrmangohands mrmangohands added the S-needs-triage Status: Needs triage label Aug 15, 2024
@IMS212
Copy link
Member

IMS212 commented Aug 15, 2024

This was disabled due to the weirdness surrounding NeoForge's early window, and the fact that a separate path needs to be used there. I can work on this later.

@jellysquid3 jellysquid3 added T-bug Type: Bug P-high Priority: High A-portability Area: Platform portability and removed S-needs-triage Status: Needs triage labels Aug 16, 2024
@jellysquid3
Copy link
Member

We probably can't get this fixed in a reasonable time window for Sodium 0.6, since NeoForge complicates things with their early window initialization. The important thing is making sure that our Fabric builds still have this functionality.

@IMS212
Copy link
Member

IMS212 commented Aug 16, 2024

I have already fixed Fabric support in 1744347.

@jellysquid3 jellysquid3 removed the P-high Priority: High label Aug 16, 2024
@jellysquid3 jellysquid3 changed the title No error GL context always disabled No Error Contexts are not implemented for NeoForge Aug 16, 2024
@jellysquid3
Copy link
Member

This is not solvable without changes in NeoForge, since they clear the context bits and do not give mods any way to change the context initialization behavior.

@jellysquid3 jellysquid3 added P-low Priority: Low S-blocked Status: Blocked by another issue/merge labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-portability Area: Platform portability P-low Priority: Low S-blocked Status: Blocked by another issue/merge T-bug Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants