Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent structure between fabric and forge subprojects, mixin rules don't apply to platform specific code #2688

Closed
mrmangohands opened this issue Aug 17, 2024 · 1 comment
Labels
S-needs-triage Status: Needs triage

Comments

@mrmangohands
Copy link
Member

mrmangohands commented Aug 17, 2024

Bug Description

Currently fabric specific mixins are located under the sodium.mixin.fabric package while neoforge ones are under sodium.neoforge.mixin. Neither of these layouts let mixin rules from common apply to mixins in the subprojects. Either the mixin rule system would need to be updated to apply automatically to matching subpackages in the subprojects, or both could just use sodium.mixin as the base, with a neoforge, fabric, or generically platform bottom level subpackage. So for example instead of sodium.mixin.fabric.core.WindowMixin you could have sodium.mixin.core.fabric.WindowMixin.

We should decide which of the 3 layouts we'd like to go with. The first and third options can be combined if desired. Packages that have a match in common or the other platform could use a bottom level platform package, and either everything else or just the Mixins that provide platform specific APIs could use the top level one.

@mrmangohands mrmangohands added the S-needs-triage Status: Needs triage label Aug 17, 2024
@mrmangohands
Copy link
Member Author

Edited for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-triage Status: Needs triage
Projects
None yet
Development

No branches or pull requests

1 participant