Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader Line Annotation #2691

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

douira
Copy link
Collaborator

@douira douira commented Aug 19, 2024

  • add line directive insertion to ShaderParser,
  • use assigned source ids to remap the sources in shader compilation logs,
  • print merged shader sources to the log file in dev environments

Fixes #2680

@douira
Copy link
Collaborator Author

douira commented Aug 19, 2024

Please test if the included regex of the form \d+:\d+: works for the shader compilation logs produced by other drivers. If not, I'll adjust the regex to also match those. Also please test that the line numbers produced in the errors actually correspond to the line numbers in the source files, to make sure the drivers aren't interpreting the line directive differently.

@douira
Copy link
Collaborator Author

douira commented Oct 18, 2024

Removed remapping code, should be good to go now.

@douira douira changed the title Shader Line Annotation and Error Remapping Shader Line Annotation Oct 21, 2024
@douira douira added the T-enhancement Type: Enhancement label Oct 21, 2024
use assigned source ids to remap the sources in shader compilation logs,
print merged shader sources to the log file in dev environments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add line numbers to merged shader sources and improve the debugging experience
1 participant