You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exceptions thrown in ActivateItemAsync, including all other methods called from the default implementation (TryDeactivateAsync, TryActivateAsync, NotifyOfPropertyChange, OnActivationProcessed) are silently discarded.
When selecting an item in a WPF ListBox, nothing happens. This is especially bad if there is additional code after the exception, which is simply not being executed without any indication.
I've found a similar issue #745 which is probably related.
The reason is that the setter of ActiveItem calls ActivateItemAsync without awaiting the task. This is a regression from 3.x. I realize awaiting in a setter is not possible and this might be a design issue:
Exceptions thrown in
ActivateItemAsync
, including all other methods called from the default implementation (TryDeactivateAsync
,TryActivateAsync
,NotifyOfPropertyChange
,OnActivationProcessed
) are silently discarded.Repro:
When selecting an item in a WPF ListBox, nothing happens. This is especially bad if there is additional code after the exception, which is simply not being executed without any indication.
I've found a similar issue #745 which is probably related.
The reason is that the setter of
ActiveItem
callsActivateItemAsync
without awaiting the task. This is a regression from 3.x. I realize awaiting in a setter is not possible and this might be a design issue:Caliburn.Micro/src/Caliburn.Micro.Core/ConductorBaseWithActiveItem.cs
Line 20 in 145c480
The text was updated successfully, but these errors were encountered: