Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RV curve file contains all results for an object #39

Open
cgelino opened this issue Oct 19, 2020 · 3 comments
Open

RV curve file contains all results for an object #39

cgelino opened this issue Oct 19, 2020 · 3 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@cgelino
Copy link
Collaborator

cgelino commented Oct 19, 2020

I want to run the template, rv, and rvcurve for a single night, but when I look at the RV curve file for that object, it contains all of RV measurements for that object that were previously run and dumped in my workspace. There should be a way for users to start fresh with an object either by allowing them to easily wipe out the previous results or allowing them to name the file of the resulting RV curve.

@bjfultn bjfultn self-assigned this Oct 20, 2020
@bjfultn
Copy link
Collaborator

bjfultn commented Oct 20, 2020

The default behavior is indeed to include all observations of a given target going back to the beginning of the bulk reduction. However, it should be possible to exclude observations from the final RV timeseries using the "deactivation" features described in the Advanced Usage tutorial (https://caltech-ipac.github.io/hiresprv/tutorials/Advanced_Usage.html).

@bjfultn bjfultn added the wontfix This will not be worked on label Oct 20, 2020
@cgelino
Copy link
Collaborator Author

cgelino commented Oct 20, 2020 via email

@bjfultn
Copy link
Collaborator

bjfultn commented Oct 26, 2020

I looked into implementing a convenience function to activate/deactivate all pre-reduced data. However we don't have a column in the database that allows us to differentiate pre-reduced data from new data. In addition, we allow the users to reprocess any of the old data and we have no way of knowing whether that has taken place.

Scientifically I don't think there is much of a use case for deactivating all of the pre-reduced RVs. The more RVs that are in the final time series the more reliable they all get due to the statistical weighting and outlier rejection that happens in the "vanking" phase. If users want to analyze only their new data they should still include most/all of the pre-processed data in the reduction but then simply ignore the measurements in the final RV timeseries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants