Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJD in database for legacy data is incorrect #53

Open
cgelino opened this issue Nov 2, 2020 · 5 comments
Open

MJD in database for legacy data is incorrect #53

cgelino opened this issue Nov 2, 2020 · 5 comments
Assignees
Labels
help wanted Extra attention is needed priority:high

Comments

@cgelino
Copy link
Collaborator

cgelino commented Nov 2, 2020

The MJD values for all of the legacy data in the database are incorrect. They are all 2.400000e+06.

@bjfultn bjfultn added help wanted Extra attention is needed priority:high labels Nov 2, 2020
@bjfultn
Copy link
Collaborator

bjfultn commented Nov 2, 2020

Could you show an example of some of the rows? This may only be an issue for certain types of rows in the DB. The basic data reduction tutorial shows that the MJD values are good for at least some of the rows.

@JohnGood might be able to comment further about what rows might not have good values in all columns.

@cgelino
Copy link
Collaborator Author

cgelino commented Nov 2, 2020

search_string = "select DATE, OBTYPE, FILENAME, TARGET, MJD, BJD from FILES where TARGET like 'HD185144';"

url = state.search(sql=search_string)
df = pd.read_html(url, header=0)[0]
df

  DATE OBTYPE FILENAME TARGET MJD BJD
20040821 RV observation r20040821.111 HD185144 2.400000e+06 2.452996e+06
20040821 RV observation r20040821.112 HD185144 2.400000e+06 2.452996e+06
20040821 RV observation r20040821.113 HD185144 2.400000e+06 2.452996e+06
20040821 RV observation r20040821.114 HD185144 2.400000e+06 2.452996e+06
20040821 RV observation r20040821.115 HD185144 2.400000e+06 2.452996e+06
... ... ... ... ... ...
20170706 RV observation r20170706.115 HD185144 2.400000e+06 2.457941e+06
20170706 RV observation r20170706.116 HD185144 2.400000e+06 2.457941e+06
20180922 RV observation r20180922.60 HD185144 2.458384e+06 2.458384e+06
20180922 RV observation r20180922.61 HD185144 2.458384e+06 2.458384e+06
20180922 RV observation r20180922.62 HD185144 2.458384e+06 2.458384e+06

@cgelino
Copy link
Collaborator Author

cgelino commented Nov 2, 2020

search_string = "select DATE, OBTYPE, FILENAME, TARGET, MJD, BJD from FILES where TARGET like 'HD19773';"

url = state.search(sql=search_string)
df = pd.read_html(url, header=0)[0]
df

  DATE OBTYPE FILENAME TARGET MJD BJD
20041024 RV observation r20041024.183 HD19773 2.400000e+06 2.452999e+06
20050225 RV observation r20050225.138 HD19773 2.400000e+06 2.453366e+06
20060821 RV observation r20060821.330 HD19773 2.400000e+06 2.453727e+06
20060903 RV observation r20060903.259 HD19773 2.400000e+06 2.453709e+06
20060904 RV observation r20060904.266 HD19773 2.400000e+06 2.453710e+06
20060905 RV observation r20060905.235 HD19773 2.400000e+06 2.453711e+06
20061215 RV observation r20061215.150 HD19773 2.400000e+06 2.453721e+06
20070129 RV observation r20070129.139 HD19773 2.400000e+06 2.454100e+06
20070806 RV observation r20070806.207 HD19773 2.400000e+06 2.454077e+06
20180815 RV observation r20180815.81 HD19773 2.400000e+06 2.458104e+06
20180815 RV observation r20180815.90 HD19773 2.400000e+06 2.458104e+06
20060906 RV observation r20060906.235 HD19773 2.400000e+06 2.453985e+06
20061015 RV observation r20061015.209 HD19773 2.400000e+06 2.454024e+06
20071123 RV observation r20071123.179 HD19773 2.400000e+06 2.454428e+06
20180905 RV observation r20180905.78 HD19773 2.458367e+06 2.458367e+06
20180905 Template r20180905.83 HD19773 2.458367e+06 2.458367e+06

@cgelino
Copy link
Collaborator Author

cgelino commented Nov 2, 2020

Uh, the column spacing got messed up on that. The "Target" column is actually the MJD

@bjfultn
Copy link
Collaborator

bjfultn commented Nov 2, 2020

Interesting, @JohnGood are we missing the MJD field (last column) in kbcvel.ascii during the initial workspace database initialization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed priority:high
Projects
None yet
Development

No branches or pull requests

3 participants