From 380d9580107f6bd05cd7d44df368105ab1d083da Mon Sep 17 00:00:00 2001 From: Alessandro Rodi Date: Thu, 23 May 2024 14:07:21 +0200 Subject: [PATCH] Do not run rails >= 7 on ruby < 3 --- .github/workflows/test.yml | 4 ++++ Appraisals | 4 ++-- gemfiles/activerecord_7.1.0.gemfile | 2 +- gemfiles/activerecord_main.gemfile | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cf5a881c..dfc147e6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -32,6 +32,10 @@ jobs: exclude: - gemfile: 'gemfiles/activerecord_5.2.2.gemfile' ruby: '3.0' # rails 5.2 can't run on ruby 3.0 + - gemfile: 'gemfiles/activerecord_7.0.0.gemfile' + ruby: '2.7' + - gemfile: 'gemfiles/activerecord_7.1.0.gemfile' + ruby: '2.7' - gemfile: 'gemfiles/activerecord_6.1.0.gemfile' ruby: 'jruby' # this *should* work. it seems like there's an issue with rails 6 on jruby. - gemfile: 'gemfiles/activerecord_main.gemfile' diff --git a/Appraisals b/Appraisals index 06150aa3..2bb71a21 100644 --- a/Appraisals +++ b/Appraisals @@ -79,7 +79,7 @@ appraise 'activerecord_7.1.0' do platforms :ruby, :mswin, :mingw do gem 'pg', '~> 1.5.6' - gem 'sqlite3', '~> 2.0.1' + gem 'sqlite3', '~> 1.7.3' end end @@ -98,6 +98,6 @@ appraise 'activerecord_main' do platforms :ruby, :mswin, :mingw do gem 'pg', '~> 1.5.6' - gem 'sqlite3', '~> 2.0.1' + gem 'sqlite3', '~> 1.7.3' end end diff --git a/gemfiles/activerecord_7.1.0.gemfile b/gemfiles/activerecord_7.1.0.gemfile index bdbcf35e..72952c7b 100644 --- a/gemfiles/activerecord_7.1.0.gemfile +++ b/gemfiles/activerecord_7.1.0.gemfile @@ -14,7 +14,7 @@ end platforms :ruby, :mswin, :mingw do gem "pg", "~> 1.5.6" - gem "sqlite3", "~> 2.0.1" + gem "sqlite3", "~> 1.7.3" end gemspec path: "../" diff --git a/gemfiles/activerecord_main.gemfile b/gemfiles/activerecord_main.gemfile index d1103eeb..cbc6172c 100644 --- a/gemfiles/activerecord_main.gemfile +++ b/gemfiles/activerecord_main.gemfile @@ -16,7 +16,7 @@ end platforms :ruby, :mswin, :mingw do gem "pg", "~> 1.5.6" - gem "sqlite3", "~> 2.0.1" + gem "sqlite3", "~> 1.7.3" end gemspec path: "../"