Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Adopting ICS-029 IBC Fee Payment #121

Open
dongsam opened this issue Mar 25, 2024 · 0 comments
Open

[Discussion] Adopting ICS-029 IBC Fee Payment #121

dongsam opened this issue Mar 25, 2024 · 0 comments

Comments

@dongsam
Copy link
Collaborator

dongsam commented Mar 25, 2024

Context:

Suggestions:

  • Adopting ICS-029 involves adding a fee module, module account, and processing via middleware, increasing complexity and potential security risks.
  • Given that this feature is not yet externally vetted or guaranteed for stability, it's advisable to prioritize the v0.50 upgrade first. ICS-029 can be considered for future adoption after ensuring its stability and necessity.

Action Items:

  • If immediate adoption is deemed unnecessary, remove the fee module from the ongoing v0.50 bump PR.
  • If future adoption is required, proceed with code validation and risk assessment for the fee module and middleware logic before introducing it in a subsequent upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant