Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Footer #486

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improve the Footer #486

wants to merge 6 commits into from

Conversation

Glng3r
Copy link

@Glng3r Glng3r commented Jun 3, 2024

Updated the footer, pin icon opens up google maps to Herzberg Laboratories and the email icon opens up email. Let me know if something doesn't look right

image

@Glng3r Glng3r requested a review from a team as a code owner June 3, 2024 18:23
Copy link
Contributor

github-actions bot commented Jun 3, 2024

🎊 PR Preview 4af7b6a has been successfully built and deployed to https://CarletonComputerScienceSociety-website-build_preview-pr-486.surge.sh

🕐 Build time: 0.009s

🤖 By surge-preview

@Glng3r Glng3r changed the title Update footer Improve the Footer Jun 3, 2024
@Glng3r Glng3r linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@ryangchung ryangchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pin could be smaller, and aligned to the line. Also, on hover, the address could show underlined and can also be clicked to go to the google maps link.

cc @MathyouMB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Footer
2 participants