-
Notifications
You must be signed in to change notification settings - Fork 29
OSC is tiny when match refresh is enabled #45
Comments
I cherry-picked the commit from PR: iina#3527 Since native mode is enabled, I think it's the expected behavior |
There is developer expected behavior and then there is user expected behavior. I'm guessing users are not going to expect that syncing = shrinking. Anyway I entered this issue to remember to look into if there is anything that can be done different. Trying to finish a few other things before looking into new stuff. It may well be that this behavior has to be accepted. |
It should not be hard to change the behavior. Lets have some investigations |
I tried to go back to working on what I was working on and failed. I had to at least take a quick look at this. My conclusion is it needs a close review. I have some of the same questions raised in the issue the PR addresses about whether the mpv features should be used. Discussion about that here: Display synchronization I added some logging for debugging and I think the following is behavior is wrong? Playing a HDR video with a high frame rate:
The code decides to look for:
The native refresh rates found:
And the code picks??:
Changing this code: if ((displayMode.ioFlags & UInt32(kDisplayModeNativeFlag) != 0) &&
displayMode.refreshRate.distance(to: refreshRate) < 0.02) { To be: if ((displayMode.ioFlags & UInt32(kDisplayModeNativeFlag) != 0) &&
abs(displayMode.refreshRate.distance(to: refreshRate)) < 0.02) { And the code picks:
I'm thinking that is what it should be choosing? I'm also getting some audio glitches. Going to try and go back to what I was doing and come back to this later... |
I was unable to put this down. I looked into this some more. The issue I mentioned above is definitely a bug. I see other problems as well. I will work on a full review and see if the author is around to make updates. |
I've posted my concerns about this feature in issue iina#3414. With respects to this particular issue the macOS behavior seems odd. |
I removed However I like this feature, let's get it back when major issues are resolved. |
I'm ready to take this one over if the original author does not have the time to address the issues. |
Unfortunately, it does not seem to be possible to preserve HiDPI (Scaled) setting when switching to a different display mode programmatically. There is no API to change the DPI scale programmatically, either. You would have to find a way to do that. Or, maybe IINA can make itself bigger (application-level HiDPI scaling). |
System and IINA version:
Expected behavior:
The preference
Match refresh rate in fullscreen
does not change the size of the OSC.Actual behavior:
On a 16" Macbook Pro with the M1 chip enabling
Match refresh rate in fullscreen
under Preferences - Video/Audio results in a tiny OSC as seen here:With
Match refresh rate in fullscreen
disabled:The macOS menu bar is also tiny:
mpv log:
Steps to reproduce:
Enable
Match refresh rate in fullscreen
under Preferences - Video/Audio and play a video in full screen.How often does this happen?
Every time
The text was updated successfully, but these errors were encountered: