Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Check if metadata check for labels is broken for hosts #10

Open
Munsio opened this issue May 29, 2017 · 3 comments
Open

Check if metadata check for labels is broken for hosts #10

Munsio opened this issue May 29, 2017 · 3 comments

Comments

@Munsio
Copy link
Member

Munsio commented May 29, 2017

As mentioned in: CausticLab/rgon-proxy#32

The rgon.ssl label on the host machine doesn't trigger an acmetool want like described in the config file.
It could be that rancher-gen doesn't recognize the label on the host.
Maybe it is cause we set an "boolean" value.

@Munsio
Copy link
Member Author

Munsio commented May 29, 2017

Found it:
https://github.com/CausticLab/go-rancher-gen/blob/master/runner.go#L269

We only check containers for there labels not hosts

@emcniece
Copy link
Member

Oops... yep, that's my fault for not implementing. I really should have made a TODO note :(

@Munsio
Copy link
Member Author

Munsio commented May 29, 2017

I will look deeper into this but i have this feeling that this would be a larger rewrite ^^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants