Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.7.0] Autocompletion in search #604

Open
SevenSpheres opened this issue Feb 10, 2020 · 4 comments · May be fixed by #1329
Open

[1.7.0] Autocompletion in search #604

SevenSpheres opened this issue Feb 10, 2020 · 4 comments · May be fixed by #1329
Labels
wishlist

Comments

@SevenSpheres
Copy link
Contributor

In Celestia 1.7.0, when you type a partial string into the search box and press Enter, the first object matching that string is selected. For example if I type jup and then press Enter, Jupiter is selected. I assume this was intended to be a new feature, but it causes a bug: if I type, say, eps ind b, Eps Ind Ba (the first object in the list) is selected, instead of the Eps Ind B barycenter. I think this "feature" should just be removed, and the search should work as it does in 1.6.x.
@SevenSpheres
Copy link
Contributor Author

SevenSpheres commented Feb 15, 2020 •
edited
Loading

"Wishlist"? I'm basically asking for a new "feature" to be reverted. There are some other things I'll tag as wishlist though...

@SevenSpheres SevenSpheres added bug Something isn't working and removed wishlist labels Feb 15, 2020
@375gnu
Copy link
Collaborator

375gnu commented Feb 15, 2020

for me this is not a bug

@LukeCEL LukeCEL mentioned this issue Feb 28, 2020
Closed
@SevenSpheres
Copy link
Contributor Author

@375gnu maybe @LukeCEL explained it more clearly in #629?

@SevenSpheres SevenSpheres changed the title Autocompletion in search [1.7.0] Autocompletion in search Jul 26, 2020
@375gnu 375gnu added wishlist and removed bug Something isn't working labels Jun 6, 2021
@375gnu
Copy link
Collaborator

375gnu commented Nov 25, 2021

This was introduced in 1495531, we can hide it behind #ifdef AUTO_COMPLETION

375gnu added a commit that referenced this issue Jan 20, 2022
@375gnu
Don't use suggestions if object searched is not found
6a3f93a 
Closes: #604
@375gnu 375gnu linked a pull request Jan 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wishlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use suggestions if object searched is not found CelestiaProject/Celestia
2 participants
@375gnu @SevenSpheres