Feature/bootstrap #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktaal
reviewed
Dec 16, 2024
{{cookiecutter.slug}}/frontend.angular/src/app/menu/menu.component.html
Outdated
Show resolved
Hide resolved
{{cookiecutter.slug}}/frontend.angular/src/app/footer/footer.component.html
Outdated
Show resolved
Hide resolved
| <nav class="navbar navbar-expand-lg bg-body-tertiary" aria-label="main navigation" | ||
| data-bs-theme="dark"> | ||
| <div class="container-fluid"> | ||
| <div class="navbar-brand" i18n> |
There was a problem hiding this comment.
Aaaaaargh this is apparently standard Bootstrap (added the line to highlight the nope-nope-nope)
{{cookiecutter.slug}}/frontend.angular/src/app/menu/menu.component.html
Outdated
Show resolved
Hide resolved
| $yellow: #FFCD00, | ||
| $blue: #5287C6); | ||
| @use 'bulma/bulma'; | ||
| @use 'bootstrap'; |
There was a problem hiding this comment.
Perhaps something like
// University Brand Colors
$primary: #FFCD00;
$green: #24A793;
$success: $green;
$red: #C00A35;
$danger: $red;
$yellow: #FFCD00;
$warning: $yellow;
$blue: #5287C6;
$info: $blue;
$link-color: $blue;
$link-color-dark: $blue;
@import "bootstrap/scss/bootstrap.scss";To not lose the UU colors (the yellow in the menu is quite something though)
There was a problem hiding this comment.
Most of our applications don't use UU brand colours, but since we're switching to bootstrap, I know ITS has a UU bootstrap theme (which they use for Yoda), and I think portaldev or ILS may have made one too?
I hadn't looked into this yet, but when that becomes relevant, we can probably borrow something instead of making our own theme.
Co-Authored-By: Sheean Spoel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces bulma and primeNG with bootstrap / ng-bootstrap.
Also closes #52 (which was a bulma issue)