Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML extractor: multiple overrides parent_level #9

Closed
lukavdplas opened this issue Mar 1, 2024 · 1 comment · Fixed by #18
Closed

XML extractor: multiple overrides parent_level #9

lukavdplas opened this issue Mar 1, 2024 · 1 comment · Fixed by #18
Labels
bug Something isn't working

Comments

@lukavdplas
Copy link
Contributor

The implementation of parent_level in the XML extractor seems to suggest that parent_level has no effect if multiple is set to True:

https://github.com/UUDigitalHumanitieslab/ianalyzer-readers/blob/008749c734ecce6d934cb52b50797e63de460b63/ianalyzer_readers/extract.py#L238-L248

I don't think there is any reason why you shouldn't be able to combine those extractors. (So search from the parent level, and return all matching tags.) I think this is just a bug where we never tested the intersection of these properties.
@lukavdplas lukavdplas added the bug Something isn't working label Mar 1, 2024
@lukavdplas lukavdplas changed the title XML extractor: multiple overrides parent_level? XML extractor: multiple overrides parent_level Mar 4, 2024
@lukavdplas lukavdplas mentioned this issue Mar 5, 2024
Closed
@lukavdplas lukavdplas mentioned this issue Apr 30, 2024
Merged
@lukavdplas lukavdplas linked a pull request Apr 30, 2024 that will close this issue
Feature/redesign xml reader #18
Merged
@lukavdplas
Copy link
Contributor Author

closed by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/redesign xml reader CentreForDigitalHumanities/ianalyzer-readers
1 participant
@lukavdplas