From bc43046c56b4975cf713d80a3be8bd2f26699d64 Mon Sep 17 00:00:00 2001 From: Luka van der Plas Date: Fri, 27 Sep 2024 12:45:10 +0200 Subject: [PATCH] show filled icon for identifiable locations --- frontend/generated/graphql.ts | 7 +++++-- frontend/generated/schema.graphql | 1 + .../data-entry/location-form/location-form.component.html | 2 +- .../app/data-entry/location-form/space-description.graphql | 1 + .../source/episode-preview/episode-preview.component.html | 3 ++- frontend/src/app/data-entry/source/source.graphql | 1 + frontend/src/app/shared/icons.ts | 1 + 7 files changed, 12 insertions(+), 4 deletions(-) diff --git a/frontend/generated/graphql.ts b/frontend/generated/graphql.ts index 7c3a0df3..c5993a6d 100644 --- a/frontend/generated/graphql.ts +++ b/frontend/generated/graphql.ts @@ -808,6 +808,7 @@ export type SpaceDescriptionType = EntityDescription & { /** Relevant (Latin) terminology used to describe this entity in the source text */ designators: Array; episodes: Array; + hasIdentifiableFeatures: Scalars['Boolean']['output']; id: Scalars['ID']['output']; name: Scalars['String']['output']; /** The page number or page range in the source */ @@ -1216,7 +1217,7 @@ export type DataEntrySpaceDescriptionQueryVariables = Exact<{ }>; -export type DataEntrySpaceDescriptionQuery = { __typename?: 'Query', spaceDescription?: { __typename?: 'SpaceDescriptionType', id: string, name: string, description: string, source: { __typename?: 'SourceType', id: string, name: string } } | null }; +export type DataEntrySpaceDescriptionQuery = { __typename?: 'Query', spaceDescription?: { __typename?: 'SpaceDescriptionType', id: string, name: string, description: string, hasIdentifiableFeatures: boolean, source: { __typename?: 'SourceType', id: string, name: string } } | null }; export type DataEntryEpisodeEntityLinkQueryVariables = Exact<{ entity: Scalars['ID']['input']; @@ -1246,7 +1247,7 @@ export type DataEntrySourceDetailQueryVariables = Exact<{ }>; -export type DataEntrySourceDetailQuery = { __typename?: 'Query', source: { __typename?: 'SourceType', id: string, name: string, episodes: Array<{ __typename?: 'EpisodeType', id: string, name: string, description: string, summary: string, book: string, chapter: string, page: string, contributors: Array<{ __typename?: 'UserType', id: string, fullName: string }>, agents: Array<{ __typename?: 'AgentDescriptionType', id: string, name: string, isGroup: boolean, describes: Array<{ __typename?: 'HistoricalPersonType', id: string, identifiable: boolean }> }>, gifts: Array<{ __typename?: 'GiftDescriptionType', id: string, name: string }>, letters: Array<{ __typename?: 'LetterDescriptionType', id: string, name: string }>, spaces: Array<{ __typename?: 'SpaceDescriptionType', id: string, name: string }> }> } }; +export type DataEntrySourceDetailQuery = { __typename?: 'Query', source: { __typename?: 'SourceType', id: string, name: string, episodes: Array<{ __typename?: 'EpisodeType', id: string, name: string, description: string, summary: string, book: string, chapter: string, page: string, contributors: Array<{ __typename?: 'UserType', id: string, fullName: string }>, agents: Array<{ __typename?: 'AgentDescriptionType', id: string, name: string, isGroup: boolean, describes: Array<{ __typename?: 'HistoricalPersonType', id: string, identifiable: boolean }> }>, gifts: Array<{ __typename?: 'GiftDescriptionType', id: string, name: string }>, letters: Array<{ __typename?: 'LetterDescriptionType', id: string, name: string }>, spaces: Array<{ __typename?: 'SpaceDescriptionType', id: string, name: string, hasIdentifiableFeatures: boolean }> }> } }; export type DataEntrySourceListQueryVariables = Exact<{ [key: string]: never; }>; @@ -1988,6 +1989,7 @@ export const DataEntrySpaceDescriptionDocument = gql` id name description + hasIdentifiableFeatures source { id name @@ -2115,6 +2117,7 @@ export const DataEntrySourceDetailDocument = gql` spaces { id name + hasIdentifiableFeatures } } } diff --git a/frontend/generated/schema.graphql b/frontend/generated/schema.graphql index 163a7ea9..af0629d3 100644 --- a/frontend/generated/schema.graphql +++ b/frontend/generated/schema.graphql @@ -674,6 +674,7 @@ type SpaceDescriptionType implements EntityDescription { """ designators: [String!]! episodes: [EpisodeSpaceType!]! + hasIdentifiableFeatures: Boolean! id: ID! name: String! diff --git a/frontend/src/app/data-entry/location-form/location-form.component.html b/frontend/src/app/data-entry/location-form/location-form.component.html index 42079d5a..053a85b7 100644 --- a/frontend/src/app/data-entry/location-form/location-form.component.html +++ b/frontend/src/app/data-entry/location-form/location-form.component.html @@ -3,7 +3,7 @@

- + {{spaceDescription.name}} ({{spaceDescription.source.name}}) diff --git a/frontend/src/app/data-entry/location-form/space-description.graphql b/frontend/src/app/data-entry/location-form/space-description.graphql index e3aea7cf..f99a96c8 100644 --- a/frontend/src/app/data-entry/location-form/space-description.graphql +++ b/frontend/src/app/data-entry/location-form/space-description.graphql @@ -3,6 +3,7 @@ query DataEntrySpaceDescription($id: ID!) { id name description + hasIdentifiableFeatures source { id name diff --git a/frontend/src/app/data-entry/source/episode-preview/episode-preview.component.html b/frontend/src/app/data-entry/source/episode-preview/episode-preview.component.html index cbeae8e6..0075d21a 100644 --- a/frontend/src/app/data-entry/source/episode-preview/episode-preview.component.html +++ b/frontend/src/app/data-entry/source/episode-preview/episode-preview.component.html @@ -58,7 +58,8 @@ [routerLink]="['/data-entry', 'locations', space.id]" class="icon-link" > - + {{ space.name }} diff --git a/frontend/src/app/data-entry/source/source.graphql b/frontend/src/app/data-entry/source/source.graphql index 0d3d633e..27f5405a 100644 --- a/frontend/src/app/data-entry/source/source.graphql +++ b/frontend/src/app/data-entry/source/source.graphql @@ -34,6 +34,7 @@ query DataEntrySourceDetail($id: ID!) { spaces { id name + hasIdentifiableFeatures } } } diff --git a/frontend/src/app/shared/icons.ts b/frontend/src/app/shared/icons.ts index 33ba1cac..0d1360c9 100644 --- a/frontend/src/app/shared/icons.ts +++ b/frontend/src/app/shared/icons.ts @@ -31,6 +31,7 @@ export const dataIcons = { personUnknown: 'person', group: 'people', location: 'geo-alt', + locationIdentified: 'geo-alt-fill', gift: 'gift', letter: 'envelope', };