Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account and support menus broken on narrow viewports #155

Open
guyaparker opened this issue Mar 26, 2018 · 2 comments
Open

Account and support menus broken on narrow viewports #155

guyaparker opened this issue Mar 26, 2018 · 2 comments

Comments

@guyaparker
Copy link

guyaparker commented Mar 26, 2018

The account and support menus render badly on narrow viewports and some links become unclickable. They worked on the 1.8.3 sample pages (e.g. http://assets.ctl.io/cyclops/1.8.3/starterPages/basic.html):

screen shot 2018-03-26 at 12 09 35

But are broken on 1.8.4 (e.g. http://assets.ctl.io/cyclops/1.8.4/starterPages/basic.html)::

screen shot 2018-03-26 at 12 13 16

I've tried sample page tests with and without the GlobalNavMenu included and believe the issue is related to changes in Cyclops for the GlobalNavMenu rather than the GlobalNavMenu causing the issues.

These changes seem to be involved:
c62ed55#diff-11f7153e01dbe9d55a1908a075d9326a
12dd143#diff-11f7153e01dbe9d55a1908a075d9326a

When the GlobalNavMenu includes a support menu the issue becomes even worse:

screen shot 2018-03-26 at 12 21 51

@guyaparker
Copy link
Author

I think these over rides fix it:

@media (max-width: 991px) { global-menu-support .items-list { right: auto !important; } global-menu-support .arrow { right: auto !important; left:24px !important; } html.cyclops .dropdown .dropdown-menu.dropdown-menu-right { right: auto; left: 0; } html.cyclops .navbar-static-top .open .dropdown-menu { position: absolute; background-color: #fff; border: 1px solid #d5d5d5; box-shadow: 0 2px 8px rgba(24,26,30,.2); } }

screen shot 2018-03-26 at 14 26 04

@aryaroudi
Copy link
Contributor

aryaroudi commented Aug 28, 2019

#175 Hey @guyaparker I guess this PR will fix your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants