Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in SDK code exposed to users #4

Open
Tolk-Haggard opened this issue Jun 18, 2015 · 1 comment
Open

Exceptions in SDK code exposed to users #4

Tolk-Haggard opened this issue Jun 18, 2015 · 1 comment

Comments

@Tolk-Haggard
Copy link

The CenturyLInkCloudServiceException may be populated with an inner exception unexpectedly thrown from within the SDK which would not provide the user with any valuable information while revealing problems within the SDK itself.

For example, consider a bug introduced into the DeserializeAPIErrorMessage method for the following line:
https://github.com/CenturyLinkCloud/CenturyLinkCloud-.NET-SDK/blob/master/CenturyLinkCloudSDK/Runtime/ServiceInvoker.cs#L62
This exception would be caught and then returned inside the CenturyLinkCloudServiceException to the consumer.

@rpierry
Copy link
Contributor

rpierry commented Jun 23, 2015

I have refactored serviceinvoker, but in general we attempt to provide the inner exception because it is usually the underlying cause of the issue (something http related from a failed request, a failure to parse because the response was unexpected, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants