Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using FamilyInstance.Symbol for improved instancing #54

Open
corybarr opened this issue Aug 26, 2024 · 2 comments
Open

Investigate using FamilyInstance.Symbol for improved instancing #54

corybarr opened this issue Aug 26, 2024 · 2 comments
Labels
GTM Issues to be addressed prior to GTM

Comments

@corybarr
Copy link
Contributor

corybarr commented Aug 26, 2024

(This is arguably not necessary for GTM.)

It might be possible to enhance instancing by using the FamilySymbol member of an element's FamilyInstance object. For example, when instancing via hashing geometry objects, only two of these 5 benches instance. However, they all share the same Symbol reference:

image

A point of confusion is that these benches export with differing numbers of verts and faces, which is why they fail the hash test for instancing. However, they look like genuine instances in other ways.

It might be possible to do away with hashing geometry data completely. The addin spends ~50% of its time serializing the data to hash.

@corybarr corybarr added the GTM Issues to be addressed prior to GTM label Sep 16, 2024
@r-veenstra
Copy link
Contributor

@corybarr is this still relevant for GTM?

@corybarr
Copy link
Contributor Author

I think it's more of a need before open sourcing. If we plan to open-source at GTM, then I say yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTM Issues to be addressed prior to GTM
Projects
None yet
Development

No branches or pull requests

2 participants