-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate-gltf-classes: Request glTF schema files from github instead of embedding as a submodule #108
Comments
Although I already did that/tried out that download approach locally, it's only a small change. I can create a PR for that, but would probably do that after the main PR is merged. (Or should I just plug it on top of the |
I have added this for now in https://github.com/CesiumGS/cesium-native/tree/gltf-from-online-schema Depending on whether the "base paths" that are given in the |
yep agreed 👍
Great! I'm happy with either approach - PR into gltf or wait until it's merged into master. |
Fixed via #121 The schema is now downloaded from the Khronos repo by default, but it's also possible to change the input to be local files (this can be done in the package.json, but without any actual code changes). |
The glTF spec repo isn't tiny, and we only need it when generating glTF classes. And even then we only need the JSON schema files., which are very small compared to the whole repo. So a nice improvement (originally suggested by @javagl in #106) would be to request the schema files from github as needed, i.e. in
SchemaCache.js
instead of forcing users to download the whole glTF repo as a submodule.@javagl's suggested code in SchemaCache.js:
And in
package.json
:The text was updated successfully, but these errors were encountered: