Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartographic Polygon and Polygon Imagery layer default values #631

Closed
4 tasks done
r-veenstra opened this issue Jan 23, 2024 · 4 comments · Fixed by #649
Closed
4 tasks done

Cartographic Polygon and Polygon Imagery layer default values #631

r-veenstra opened this issue Jan 23, 2024 · 4 comments · Fixed by #649
Assignees

Comments

@r-veenstra
Copy link
Contributor

r-veenstra commented Jan 23, 2024

I suggest we implement the following default values to make using cartographic polygons and polygon overlays a little easier

Imagery Overlay

  • Overlay Render Method - clipping - same as Unreal, also less confusing as it won't immediately make the tileset black

Cartographic Polygons - defaults when creating by any method

  • point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] - Helpful to have some pre-existing points for the user to grab and edit, vs trying to draw from scratch. Unreal does this. (especially as raycasting to tilesets is not currently available)
  • uniform token type = "linear" - Helpful to avoid accidental use of curves which aren't supported
  • uniform token wrap = "periodic" - Ensures the polygon is closed

cc @corybarr

@dkbraig dkbraig assigned dkbraig and corybarr and unassigned dkbraig Jan 23, 2024
@corybarr
Copy link
Contributor

Setting point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] in the USD schema leads to a crash in Omniverse when a CesiumCartographicPolygonPrim is created. I'm seeing if this is solvable, but it might have to be done at the Python level during prim creation.

@lilleyse
Copy link
Contributor

@corybarr does that crash happen in #626?

@corybarr
Copy link
Contributor

  • point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] - Helpful to have some pre-existing points for the user to grab and edit, vs trying to draw from scratch. Unreal does this. (especially as raycasting to tilesets is not currently available)

    Create an issue with the title `point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)]` - Helpful to have some pre-existing points for the user to grab and edit, vs trying to draw from scratch.  Unreal does this. (especially as raycasting to tilesets is not currently available). Press Enter to convert to an issue instantly. Press Alt-Enter to open the create new issue form in the current tab. Press Shift-Enter to open the create new issue form.
    
  • uniform token type = "linear" - Helpful to avoid accidental use of curves which aren't supported

    Create an issue with the title `uniform token type = "linear"` - Helpful to avoid accidental use of curves which aren't supported. Press Enter to convert to an issue instantly. Press Alt-Enter to open the create new issue form in the current tab. Press Shift-Enter to open the create new issue form.
    
  • uniform token wrap = "periodic" - Ensures the polygon is closed

@lilleyse It does happen in #626. The crash's trace doesn't go through our code.

@corybarr
Copy link
Contributor

Setting point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] in the USD schema leads to a crash in Omniverse when a CesiumCartographicPolygonPrim is created. I'm seeing if this is solvable, but it might have to be done at the Python level during prim creation.

Since some attributes require setting other attributes, I tried adding curveVertexCounts and extent. I still got the crash. Given that, I copied all attributes from a working CesiumCartographicPolygonPrim but still get the instantiation-time crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants