Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CesiumRuntime requires Slate / SlateCore, but it is not listed as a dependency #1485

Open
kring opened this issue Jul 24, 2024 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers low hanging fruit

Comments

@kring
Copy link
Member

kring commented Jul 24, 2024

Our UScreenCreditsWidget, which is found in our CesiumRuntime module, uses Slate to display credits. But we're incorrectly only depending on Slate in Editor builds:

if (Target.bBuildEditor == true)
{
    PublicDependencyModuleNames.AddRange(
        new string[] {
            "UnrealEd",
            "Slate",
            "SlateCore",
            "WorldBrowser",
            "ContentBrowser",
            "MaterialEditor"
        }
    );
}

This is causing linker error in shipping builds on at least one user's system. It's not clear why it doesn't cause problems everywhere. The fix is to move Slate and SlateCore to the other list of PublicDependencyModuleNames in this file so that it's included as a dependency in all builds.

Reported here:
https://community.cesium.com/t/ue5-3-2-cesium-fails-to-package-for-windows-due-to-slate-errors/33661

@kring kring added bug Something isn't working good first issue Good for newcomers low hanging fruit labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers low hanging fruit
Projects
None yet
Development

No branches or pull requests

1 participant