Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When exiting PIE, the editor gets stuck for a long time #1523

Open
kak0na opened this issue Sep 18, 2024 · 1 comment
Open

When exiting PIE, the editor gets stuck for a long time #1523

kak0na opened this issue Sep 18, 2024 · 1 comment

Comments

@kak0na
Copy link

kak0na commented Sep 18, 2024

When exiting PIE, the editor will be stuck for a long time. It is a problem with requesting data. We can only add a timeout, but we don’t know if it is correct. Do you think we should add this judgment?

https://www.bilibili.com/video/BV1e7WBeEERR

UnrealAssetAccessor.cpp

return asyncSystem.createFuture<std::shared_ptrCesiumAsync::IAssetRequest>(
[&url, &headers, &userAgent, &cesiumRequestHeaders](const auto& promise) {
FHttpModule& httpModule = FHttpModule::Get();
TSharedRef<IHttpRequest, ESPMode::ThreadSafe> pRequest =
httpModule.CreateRequest();
pRequest->SetURL(UTF8_TO_TCHAR(url.c_str()));

    pRequest->SetTimeout(10);
    
    for (const auto& header : headers) {
      pRequest->SetHeader(
          UTF8_TO_TCHAR(header.first.c_str()),
          UTF8_TO_TCHAR(header.second.c_str()));
    }
@kring
Copy link
Member

kring commented Sep 18, 2024

Adding a timeout is ok, but it's probably better to figure out why the server is taking so long to respond to some requests in your case. That's most likely the root of the issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants