diff --git a/CHANGES.md b/CHANGES.md index 10e777d18108..003d3a93908f 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -22,6 +22,8 @@ ##### Breaking Changes :mega: +- Removed `jitter` option from `VoxelPrimitive.js`, `VoxelRenderResources.js`, and related test code in `VoxelPrimitiveSpec.js`. [#11913](https://github.com/CesiumGS/cesium/issues/11913) + - Custom specular environment maps in `ImageBasedLighting` now require either a WebGL2 context or a WebGL1 context that supports the [`EXT_shader_texture_lod` extension](https://registry.khronos.org/webgl/extensions/EXT_shader_texture_lod/). - `ScreenSpaceCameraController._zoomFactor` replaced with public zoomFactor attribute. diff --git a/packages/engine/Source/Scene/VoxelPrimitive.js b/packages/engine/Source/Scene/VoxelPrimitive.js index 7539bf155269..8a83c3ea2512 100644 --- a/packages/engine/Source/Scene/VoxelPrimitive.js +++ b/packages/engine/Source/Scene/VoxelPrimitive.js @@ -332,12 +332,6 @@ function VoxelPrimitive(options) { this._transformNormalLocalToWorld = new Matrix3(); // Rendering - /** - * @type {boolean} - * @private - */ - this._jitter = false; - /** * @type {boolean} * @private @@ -704,29 +698,6 @@ Object.defineProperties(VoxelPrimitive.prototype, { }, }, - /** - * Gets or sets whether or not to jitter the view ray during the raymarch. - * This reduces stair-step artifacts but introduces noise. - * - * @memberof VoxelPrimitive.prototype - * @type {boolean} - */ - jitter: { - get: function () { - return this._jitter; - }, - set: function (jitter) { - //>>includeStart('debug', pragmas.debug); - Check.typeOf.bool("jitter", jitter); - //>>includeEnd('debug'); - - if (this._jitter !== jitter) { - this._jitter = jitter; - this._shaderDirty = true; - } - }, - }, - /** * Gets or sets the nearest sampling. * diff --git a/packages/engine/Source/Scene/VoxelRenderResources.js b/packages/engine/Source/Scene/VoxelRenderResources.js index 407eab42a74c..c6814a95acbe 100644 --- a/packages/engine/Source/Scene/VoxelRenderResources.js +++ b/packages/engine/Source/Scene/VoxelRenderResources.js @@ -215,9 +215,6 @@ function VoxelRenderResources(primitive) { ShaderDestination.FRAGMENT ); } - if (primitive._jitter) { - shaderBuilder.addDefine("JITTER", undefined, ShaderDestination.FRAGMENT); - } if (primitive._nearestSampling) { shaderBuilder.addDefine( "NEAREST_SAMPLING", diff --git a/packages/engine/Specs/Scene/VoxelPrimitiveSpec.js b/packages/engine/Specs/Scene/VoxelPrimitiveSpec.js index 5cd5d1d7712c..d41713eca959 100644 --- a/packages/engine/Specs/Scene/VoxelPrimitiveSpec.js +++ b/packages/engine/Specs/Scene/VoxelPrimitiveSpec.js @@ -78,7 +78,6 @@ describe( }); toggleOption("depthTest", true, false); - toggleOption("jitter", false, true); toggleOption("nearestSampling", false, true); });